Cosmos Issue #5247: Address read-my-writes test failure #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 2, 2019 23:43
David-Noble-at-work
requested review from
danieljurek and
moderakh
as code owners
David-Noble-at-work
deleted the
issue/#5247/cosmos/direct-tcp/read-my-writes
branch
moderakh
reviewed
Nov 7, 2019
| @@ -73,6 +74,8 @@ public static void main(String[] args) throws Exception { | |||
| System.err.println("INVALID Usage: " + e.getMessage()); | |||
| System.err.println("Try '-help' for more information."); | |||
| throw e; | |||
| } finally { | |||
| System.exit(0); | |||
There was a problem hiding this comment.
why do we need this?
This will cause problem for tests directly invoking Main:main()
This was referenced Nov 8, 2019
David-Noble-at-work
changed the title
David-Noble-at-work
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #5247 and improves Direct TCP diagnostics. The fix to the read-my-writes test failure is a single-line change to
RntbdTransportClient. A number of other changes were made to:Improve Direct TCP diagnostics
One of the more notable improvements is the addition of
RntbdRequestRecord.Stagewhich is useful for tracking a request through its lifetime in the RNTBD request pipeline. This addition ripples through the code in a few places.An RntbdTransportClient.Options addition: requestExpiryInverval.
This option will eventually be used to cancel "lost" requests. A lost request is one which was successfully sent but for which we get no response. The default value is 5 seconds, the time within which the server guarantees a response. Rationale: requests are sometimes lost when testing under load. When these requests are lost we currently wait the full request timeout interval; 65 seconds by default. Waiting just 5 seconds to fail a lost request once sent reduces our latency significantly.
Modest azure-cosmos-benchmark package changes that I found useful in troubleshooting the read-my-writes test failure.
Import optimization, code tidying/method sorting in a couple of places.
Most of the latter two changes were ported from my working branch on the v2.6 code path. The port to v2.6 and v3.0 will follow completion of this PR.