Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct TCP: RntbdClientChannelPool should not warn about channel closures due to inactivity #275

Closed
David-Noble-at-work opened this issue Oct 14, 2019 · 0 comments
Closed

Direct TCP: RntbdClientChannelPool should not warn about channel closures due to inactivity #275

David-Noble-at-work opened this issue Oct 14, 2019 · 0 comments
Assignees
@David-Noble-at-work
Labels
needs-v3-port

Comments

@David-Noble-at-work
Copy link

David-Noble-at-work commented Oct 14, 2019 •
edited
Loading

This message should be written at debug level, not warning level:

if (logger.isWarnEnabled()) {
    logger.warn(
        "{} closing due to inactivity (time elapsed since last request: {} > idleEndpointTimeout: {})",
        endpoint, Duration.ofNanos(elapsedTime), Duration.ofNanos(idleEndpointTimeout));
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@David-Noble-at-work David-Noble-at-work

Labels
needs-v3-port
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@David-Noble-at-work