build: migrate to TypeScript 4 and remove TSLint

[xballoy]

I migrated TypeScript to the latest version but our ESLint / TSLint settings were not compatible (showing errors on valid TypeScript 4 code).

I removed TSLint which is deprecated and used eslint-config-airbnb-typescript instead so we have the same rules for both JavaScript and TypeScript.
However as we didn't use the same rules on TypeScript and JavaScript files I had to disable the following rules:

• @typescript-eslint/no-unused-vars
• react/no-array-index-key
• react/require-default-props
• import/no-named-as-default
• react/destructuring-assignment
• no-param-reassign
• no-prototype-builtins
• react/button-has-type
• @typescript-eslint/no-use-before-define

❓ Should I create issues to fix them?

I also added the following in the tsconfig to remove the * as in the TypeScript files

"esModuleInterop": true,
"allowSyntheticDefaultImports": true

Fixes #736

[xballoy]

Waiting for #645 to complete to fix master

[youf-olivier]

I migrated TypeScript to the latest version but our ESLint / TSLint settings were not compatible (showing errors on valid TypeScript 4 code).

I removed TSLint which is deprecated and used eslint-config-airbnb-typescript instead so we have the same rules for both JavaScript and TypeScript.
However as we didn't use the same rules on TypeScript and JavaScript files I had to disable the following rules:

• @typescript-eslint/no-unused-vars
• react/no-array-index-key
• react/require-default-props
• import/no-named-as-default
• react/destructuring-assignment
• no-param-reassign
• no-prototype-builtins
• react/button-has-type
• @typescript-eslint/no-use-before-define

❓ Should I create issues to fix them?

I also added the following in the tsconfig to remove the * as in the TypeScript files

"esModuleInterop": true,
"allowSyntheticDefaultImports": true

Fixes #736

Yes it could be a good idea to open issue to discuss about the lint rules.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

95.3% Coverage
0.0% Duplication