Migrate Help package to Typescript #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudforaison
changed the title
xballoy
reviewed
Jul 7, 2020
sisko59
previously approved these changes
Aug 28, 2020
romuleald
suggested changes
Sep 2, 2020
arnaudforaison
force-pushed
the
feature/migrate-ts-help
branch
3 times, most recently
from
23c97b8 to
7644e94
Compare
arnaudforaison
force-pushed
the
feature/migrate-ts-help
branch
from
7644e94 to
c9c1adb
Compare
xballoy
reviewed
Oct 21, 2020
xballoy
reviewed
Oct 21, 2020
xballoy
suggested changes
Oct 21, 2020
arnaudforaison
force-pushed
the
feature/migrate-ts-help
branch
4 times, most recently
from
621501d to
bfc7e97
Compare
xballoy
suggested changes
Oct 22, 2020
| @@ -34,7 +34,7 @@ export default { | |||
| }, | |||
| }; | |||
|
|
|||
| const Template = args => ( | |||
| const Template = (args: any) => ( | |||
There was a problem hiding this comment.
Tu peux mettre Templace: Story<PopoverProps> (où PopoverProps et le type de tes props). Story vient de storyook
|
Je n'ai rien qui s'affiche sur Popover et Help sur le storybook. |
arnaudforaison
force-pushed
the
feature/migrate-ts-help
branch
from
bfc7e97 to
1de7483
Compare
xballoy
suggested changes
Oct 23, 2020
arnaudforaison
force-pushed
the
feature/migrate-ts-help
branch
from
1de7483 to
6038114
Compare
xballoy
approved these changes
Oct 23, 2020
youf-olivier
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Migration to TypeScript for package help
Change type of compose & withClassDefault from core package