Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Test] Snapshot failed for contribute, on Help.spec when clone the master #675

Closed
sisko59 opened this issue Sep 1, 2020 · 4 comments
Closed

[Bug][Test] Snapshot failed for contribute, on Help.spec when clone the master #675

sisko59 opened this issue Sep 1, 2020 · 4 comments
Labels
Type: Bug Something isn't working
Milestone
v1.3.24

Comments

@sisko59
Copy link
Contributor

sisko59 commented Sep 1, 2020

Issue and Steps to Reproduce

check out the master.
execute the command npm run test

Versions

1.3.16

Screenshots

image
image

Expected

Tests execute successfully

Actual

Test failed on Help.spec

Additional Details
@sisko59 sisko59 mentioned this issue Sep 1, 2020
Closed
@arnaudforaison
Copy link
Contributor

arnaudforaison commented Sep 3, 2020 •
edited
Loading

A migration PR #645 is in progress and doesn't seem to have this issue.

@sisko59
Copy link
Contributor Author

sisko59 commented Sep 10, 2020 •
edited
Loading

check these PR, the issue is present:
#668
#673
#677

I think your version of master is anterior of the issue.

@sisko59 sisko59 mentioned this issue Sep 10, 2020
Merged
@arnaudforaison arnaudforaison added the Type: Bug Something isn't working label Oct 9, 2020
@arnaudforaison
Copy link
Contributor

Duplicate of #670

@arnaudforaison arnaudforaison marked this as a duplicate of #670 Oct 9, 2020
@arnaudforaison arnaudforaison added this to the v1.3.22 milestone Oct 13, 2020
@xballoy
Copy link
Contributor

xballoy commented Oct 21, 2020

Should be fixed as we do not have dependencies with local path anymore as we flatten / remove "sub-projects" in #731 and #728.

@xballoy xballoy closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
v1.3.24
Development

No branches or pull requests
3 participants
@xballoy @arnaudforaison @sisko59