-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate stories next to components #731
Conversation
f54abb6
to
8ea87fd
Compare
8ea87fd
to
71822ee
Compare
98424a5
to
4486194
Compare
@@ -0,0 +1 @@ | |||
declare module '*.md'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quoi cela sert ? Je ne me souviens plus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est pour les import des markdown dans les stories en TS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah oui les readme
Oui, c'était une erreur eslint, je n'avais même pas fait gaffe 😅
…-------- Original Message --------
On 19 Oct 2020, 18:34, Arnaud Foraison wrote:
@arnaudforaison commented on this pull request.
---------------------------------------------------------------
In [packages/Form/Input/pass/src/PassInput.stories.js](#731 (comment)):
> @@ -66,7 +63,7 @@ const PassStory = () => (
const PassInputStory = () => (
<form className="af-form" name="myform">
<div>
- <PassInput
+ <PassInputHOC
Ok je vois ça ferait une confusion entre l'export par default et l'export nommé
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#731 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAFHRYJJVMF4ENCYI3CEIGTSLRTBFANCNFSM4SV6UEZA).
|
j'ai réinstallé et lancer le storybook, ça fonctionne nickel , bravo :) Et il y a une anomalie graphique sur la démo sur le composant /story/help--html : il ne devrait pas y avoir de fond bleu, probablement du à la restructuration du composant |
Bizarre ce warning, surtout que ça build vraiment...
Je regarderais demain (et pour le help aussi).
…-------- Original Message --------
On 19 Oct 2020, 18:50, Samuel Gomez wrote:
j'ai réinstallé et lancer le storybook, ça fonctionne nickel , bravo :)
J'ai juste eu des warnings dans la console de lancement (sur toutes les stories) :
[Capture2](https://user-images.githubusercontent.com/43414022/96481164-77f75380-123b-11eb-8c14-8109f19b068c.JPG)
Et il y a une anomalie graphique sur la démo sur le composant /story/help--html :
[Capture](https://user-images.githubusercontent.com/43414022/96481383-bee54900-123b-11eb-95f6-9b258f0bc373.JPG)
il ne devrait pas y avoir de fond bleu, probablement du à la restructuration du composant
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#731 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAFHRYMZF2KPPZ25XW5QIXDSLRU5BANCNFSM4SV6UEZA).
|
4486194
to
f90005b
Compare
@samuel-gomez-axa J'ai corrigé le problème sur le popover, c'était un problème d'import (j'ai importé le composant pas le container). |
J'ai simplifié l'option |
Kudos, SonarCloud Quality Gate passed!
|
I migrated all the stories next to their component.
devDependencies
because some component use other component in their stories. I don't know if that's an issue but it's working as is.Not related to this PR but some quick improvements:
pre-commit
package because it was overriding husky and no linter was run on pre-commit.*.ts
from the TypeScript linter as we weren't linting thetsx
files. That broke the linting but I fixed it in the PR.**/*.stories.tsx
from Sonar (in addition of.js
)Fixes #726