Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to TypeScript 4 #736

Closed
xballoy opened this issue Oct 20, 2020 · 1 comment · Fixed by #765
Closed

Migrate to TypeScript 4 #736

xballoy opened this issue Oct 20, 2020 · 1 comment · Fixed by #765
Assignees
@xballoy
Labels
dependencies Pull requests that update a dependency file Type: Enhancement New feature or request
Milestone
v1.4.0

Comments

@xballoy
Copy link
Contributor

xballoy commented Oct 20, 2020

We are currently using TypeScript 3.9.7, we should migrate to TypeScript 4. To do so we should also migrate Tslint to Eslint.
@xballoy xballoy added dependencies Pull requests that update a dependency file Type: Enhancement New feature or request labels Oct 20, 2020
@arnaudforaison
Copy link
Contributor

And to fix bad practise used import * as React from 'react'

@xballoy xballoy self-assigned this Oct 21, 2020
@arnaudforaison arnaudforaison added this to the v1.4.0 milestone Oct 22, 2020
@xballoy xballoy mentioned this issue Oct 22, 2020
Merged
@mergify mergify bot closed this as completed in #765 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xballoy xballoy

Labels
dependencies Pull requests that update a dependency file Type: Enhancement New feature or request
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

build: migrate to TypeScript 4 and remove TSLint AxaFrance/react-toolkit
2 participants
@xballoy @arnaudforaison