This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Update rootstock #306
Merged
jashapiro
merged 31 commits into
AlexsLemonade:master
from
jashapiro:jashapiro/rootstock-2022-08-11
Aug 11, 2022
Merged
Update rootstock #306
jashapiro
merged 31 commits into
AlexsLemonade:master
from
jashapiro:jashapiro/rootstock-2022-08-11
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merges manubot/rootstock#399 closes manubot/rootstock#349 Co-authored-by: Anthony Gitter <[email protected]>
merges manubot/rootstock#409 * moves repeated and shared/generic functions to separate "core" plugin * reorganizes html.yaml config into first and third party plugins * removes functionality to set plugin options from url * reformats plugins with Prettier (eg 4 space tabs to 2 space) * removes anonymizer wrapper. Just make <script> tag into module to keep scope local and avoid function name conflicts. this reduces the indent of the whole script by one level. * moves plugin specific CSS to plugins themselves * adds scite plugin (uncomment to enable)
merges manubot/rootstock#419 closes manubot/rootstock#418 Co-authored-by: Daniel Himmelstein <[email protected]> Co-authored-by: Anthony Gitter <[email protected]>
merges manubot/rootstock#427 Co-authored-by: Daniel Himmelstein <[email protected]> Co-authored-by: Anthony Gitter <[email protected]>
merges manubot/rootstock#436 * allows ad-hoc builds of main that can set BUILD_DOCX=true * upgrade manubot to fix GitHub Actions URLs * build.sh: set variable defaults and lowercase
merges manubot/rootstock#444 Switches CURIE support and resolution from the Identifiers.org database to the Bioregistry, which is open source and community curated. See manubot/manubot@0205bd6
merges manubot/rootstock#449 closes manubot/rootstock#440 MANUBOT_USE_DOCKER=true instructs Manubot to use Docker for PDF export. Defaults to DOCKER_RUNNING (whether Docker is running on the system).
closes manubot/rootstock#451 merges manubot/rootstock#453 The ,, operator was introduced in bash 4.0, but bash on macOS is still version 3.2.
merges manubot/rootstock#448 Includes a full environment upgrade by removing all versions in environment.yml and allowing the conda resolver to select compatible versions. Notable upgrades include: python 3.7.8 --> 3.10.0 pandoc 2.14 --> 2.16.2 weasyprint 0.42.3 --> 53.4
merges manubot/rootstock#454 adds SPELLCHECK & MANUBOT_USE_DOCKER options to GitHub Actions triggered by workflow_dispatch.
Adds a fallback provider for DOI Content Negotiation to improve reliability of DOI metadata lookup.
merges manubot/rootstock#456 DataCite content negotiation is no longer used directly for DOIs. DOI metadata resolution should experience fewer failures, but certain fields might experience regressions. The following fields in metadata.yaml are now supported: manubot-randomize-author-order: true manubot-randomize-author-order-seed: "set a custom seed here, otherwise use HEAD git commit hash"
merges manubot/rootstock#470 closes manubot/rootstock#469 Co-authored-by: Daniel Himmelstein <[email protected]>
AppVeyor build 1.0.934 for commit 139a0a6 is now complete. Found 0 potential spelling error(s). Preview:... |
This reverts commit 139a0a6.
AppVeyor build 1.0.935 for commit 9f2e7f4 is now complete. Found 0 potential spelling error(s). Preview:... |
This was referenced Aug 11, 2022
jaclyn-taroni
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
[ci skip] This build is based on ee2e934. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/ee2e934a9be7cdc77d883c031cf763e10ed49035/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/actions/runs/2842849213
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
[ci skip] This build is based on ee2e934. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/ee2e934a9be7cdc77d883c031cf763e10ed49035/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/actions/runs/2842849213
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here, but most all of them are from directly following the instructions at https://github.com/manubot/rootstock/blob/main/SETUP.md#merging-upstream-rootstock-changes
Locally, everything still builds and looks nice, but faster and with fewer errors. Not included in this PR is the reason for the change, which was to properly support manual references, which didn't seem to work as expected before. I had actually hoped that biorxiv reference updates would be included somehow, but they appear not to be, so manual references it will be.
Sadly, the docx SVG size is also not fixed☹️
Hopefully this will also build properly in CI.