Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: MANUBOT_USE_DOCKER environment variable #449

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Nov 29, 2021

closes #440

MANUBOT_USE_DOCKER=true instructs Manubot to use Docker for PDF export. Defaults to DOCKER_RUNNING (whether Docker is running on the system).

closes manubot#440

MANUBOT_USE_DOCKER=true instructs Manubot to use Docker for PDF
export.
Defaults to DOCKER_RUNNING (whether Docker is running on the system).
@dhimmel
Copy link
Member Author

dhimmel commented Nov 29, 2021

This enables running MANUBOT_USE_DOCKER=false ./build/build.sh to use WeasyPrint for PDF export on a system with Docker running.

MANUBOT_USE_DOCKER=true ./build/build.sh will try to use Docker regardless of whether its running, possibly causing an error. But that makes sense to me if the user has specified they'd like to use docker and it's not running.

@AppVeyorBot
Copy link

AppVeyor build 1.0.267 for commit 8e5864b is now complete.

Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing
content/02.delete-me.md:44:aliqua
content/02.delete-me.md:44:amet
content/02.delete-me.md:44:consectetur
content/02.delete-me.md:44:dolore
content/02.delete-me.md:44:eiusmod
content/02.delete-me.md:44:elit
content/02.delete-me.md:44:incididunt
content/02.delete-me.md:44:ipsum
content/02.delete-me.md:44:labore
content/02.delete-me.md:44:Lorem
content/02.delete-me.md:44:magna
content/02...
The rendered manuscript from this build is temporarily available for download at:

@multimeric
Copy link

Great! This sounds like exactly what I'm after, with a sensible default too.

@dhimmel dhimmel merged commit 4ae5997 into manubot:main Nov 30, 2021
@dhimmel dhimmel deleted the issue-440 branch November 30, 2021 01:03
@agitter
Copy link
Member

agitter commented Dec 4, 2021

Great! This sounds like exactly what I'm after, with a sensible default too.

👍 This variable name and default make sense to me too. Thanks for the update @dhimmel.

ploegieku added a commit to ploegieku/2023-functional-homology-paper that referenced this pull request Aug 6, 2024
merges manubot/rootstock#449
closes manubot/rootstock#440

MANUBOT_USE_DOCKER=true instructs Manubot to use Docker for PDF export.
Defaults to DOCKER_RUNNING (whether Docker is running on the system).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionally disable the docker builds
4 participants