-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions workflow_dispatch #436
Conversation
This reverts commit dbecc62. overwriting GITHUB_SHA did not work https://github.com/dhimmel/manubot-rootstock/actions/runs/1167865853
This reverts commit 5a816b1. Did not work for development, workflow_dispatch action must be in main branch
I noticed the following issue with the output
job_url is set here, so that might need some tweaking. |
.github/workflows/manubot.yaml
Outdated
workflow_dispatch: | ||
inputs: | ||
BUILD_PDF: | ||
description: generate PDF output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we append (true or false)
to description or is that obvious?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should append (true or false)
. We may also need to make build.sh
more robust to variations in user input here. The current version is case-sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made case insensitive in ec0e455. The ,,
bash syntax for lowercasing requires bash >= 4. Not sure if that will be an issue. https://en.wikipedia.org/wiki/Bash_(Unix_shell)#Release_history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm comfortable requiring bash >= 4 given that release date.
instead of GITHUB_ACTION which had values like __run_4 on workflow_dispatch, and appears to have produced broken URLs in the past. refs manubot/rootstock#436 (comment)
merges #300 refs manubot/rootstock#436 (comment) instead of GITHUB_ACTION which had values like __run_4 on workflow_dispatch, and appears to have produced broken URLs in the past.
AppVeyor build 1.0.249 for commit b88e454 is now complete. Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscingcontent/02.delete-me.md:44:aliqua content/02.delete-me.md:44:amet content/02.delete-me.md:44:consectetur content/02.delete-me.md:44:dolore content/02.delete-me.md:44:eiusmod content/02.delete-me.md:44:elit content/02.delete-me.md:44:incididunt content/02.delete-me.md:44:ipsum content/02.delete-me.md:44:labore content/02.delete-me.md:44:Lorem content/02.delete-me.md:44:magna content/02... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks useful.
.github/workflows/manubot.yaml
Outdated
workflow_dispatch: | ||
inputs: | ||
BUILD_PDF: | ||
description: generate PDF output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should append (true or false)
. We may also need to make build.sh
more robust to variations in user input here. The current version is case-sensitive.
AppVeyor build 1.0.250 for commit 6d19282 failed. |
6d19282
to
ec0e455
Compare
AppVeyor build 1.0.251 for commit ec0e455 is now complete. Found 52 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscingcontent/02.delete-me.md:44:aliqua content/02.delete-me.md:44:amet content/02.delete-me.md:44:consectetur content/02.delete-me.md:44:dolore content/02.delete-me.md:44:eiusmod content/02.delete-me.md:44:elit content/02.delete-me.md:44:incididunt content/02.delete-me.md:44:ipsum content/02.delete-me.md:44:labore content/02.delete-me.md:44:Lorem content/02.delete-me.md:44:magna content/02... |
merges manubot/rootstock#436 * allows ad-hoc builds of main that can set BUILD_DOCX=true * upgrade manubot to fix GitHub Actions URLs * build.sh: set variable defaults and lowercase
This enables GitHub actions to run upon a
workflow_dispatch
event. Once in the main branch, this enables the following "Run workflow" menu under the Manubot workflow:I envision this being most helpful for exporting a DOCX or LaTeX version of the manuscript on an ad-hoc basis.
It would also be nice to be able to specify a past version of the repository (like a commit or tag) and rebuild that, for example to add a DOCX to an earlier version. However, that is more challenging (see dbecc62 which didn't properly override
GIHTUB_SHA
).