Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflow_dispatch #436

Merged
merged 8 commits into from
Aug 26, 2021
Merged

GitHub Actions workflow_dispatch #436

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
277daa5
github actions workflow_dispatch
dhimmel Aug 25, 2021
5a816b1
gh actions build push of workflow-dispatch branch
dhimmel Aug 25, 2021
3f2d84f
set workflow_dispatch env vars
dhimmel Aug 25, 2021
dbecc62
workflow_dispatch: allow specifying ref
dhimmel Aug 25, 2021
6f75e4e
Revert "workflow_dispatch: allow specifying ref"
dhimmel Aug 25, 2021
86515a7
Revert "gh actions build push of workflow-dispatch branch"
dhimmel Aug 25, 2021
b88e454
upgrade manubot to fix GitHub Actions URLs
dhimmel Aug 25, 2021
ec0e455
build.sh: set variable default and lowercase
dhimmel Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/manubot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ on:
branches:
- main
- master
workflow_dispatch:
inputs:
BUILD_PDF:
description: generate PDF output
Copy link
Member Author

@dhimmel dhimmel Aug 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we append (true or false) to description or is that obvious?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should append (true or false). We may also need to make build.sh more robust to variations in user input here. The current version is case-sensitive.

Copy link
Member Author

@dhimmel dhimmel Aug 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made case insensitive in ec0e455. The ,, bash syntax for lowercasing requires bash >= 4. Not sure if that will be an issue. https://en.wikipedia.org/wiki/Bash_(Unix_shell)#Release_history

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable requiring bash >= 4 given that release date.

default: "true"
BUILD_DOCX:
description: generate DOCX output
default: "false"
BUILD_LATEX:
description: generate LaTeX output
default: "false"
jobs:
manubot:
name: Manubot
Expand All @@ -21,6 +32,12 @@ jobs:
with:
# fetch entire commit history to support get_rootstock_commit
fetch-depth: 0
- name: Set Environment Variables (Workflow Dispatch)
if: github.event_name == 'workflow_dispatch'
run: |
echo "BUILD_PDF=${{ github.event.inputs.BUILD_PDF }}" >> $GITHUB_ENV
echo "BUILD_DOCX=${{ github.event.inputs.BUILD_DOCX }}" >> $GITHUB_ENV
echo "BUILD_LATEX=${{ github.event.inputs.BUILD_LATEX }}" >> $GITHUB_ENV
- name: Set Environment Variables
run: |
TRIGGERING_SHA=${GITHUB_PULL_REQUEST_SHA:-$GITHUB_SHA}
Expand Down
2 changes: 1 addition & 1 deletion build/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies:
- yamllint=1.25.0
- pip:
- errorhandler==2.0.1
- git+https://github.com/manubot/manubot@2c028a7a87be24a76e2dec3ac7db6e8754ae6d4a
- git+https://github.com/manubot/manubot@2fc85b57be896c6262398f343b550197127c0ccb
- isbnlib==3.10.3
- opentimestamps-client==0.7.0
- opentimestamps==0.4.1
Expand Down