Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: activity log table name issue #505

Conversation

bhupeshappfoster
Copy link
Collaborator

Pull Request

Description:

New plugin installs were having problem creating order due to bad column naming.

Related Issue(s):

Changes Made:

Added:

  • A migration for existing installations.

Changed:

Deprecated:

Removed:

Fixed:

  • The wrong column name from targetclass to targetClass.

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@bhupeshappfoster bhupeshappfoster merged commit 4b9bfd6 into release/3.4.0 Jun 12, 2024
@bhupeshappfoster bhupeshappfoster deleted the BP/533/activity-log-error-on-fresh-plugin-installs branch June 12, 2024 08:06
bhupeshappfoster added a commit that referenced this pull request Jul 10, 2024
* fixed: code issues before upgrading to craft5 (#499)

* updated: change logs and version bumped

* Added: hyper link field support (#504)

* Bp/524/verbb navigation plugin support (#506)

* fixed: activity log table name issue (#505)

* fixed: navigration draft and pgsql migration issue

* updated: change log

* fixed: dashboard UI issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant