fixed: code issues #499
Merged
fixed: code issues #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhupeshappfoster
commented
Apr 5, 2024
Comment on lines
-68
to
-101
| public static function populateModel($attributes) | ||
| { | ||
| if ($attributes instanceof AssetDraftRecord) { | ||
| $attributes = $attributes->getAttributes(); | ||
| } | ||
|
|
||
| $assetData = json_decode($attributes['data'], true); | ||
| $fieldContent = isset($assetData['fields']) ? $assetData['fields'] : null; | ||
| // $attributes['draftId'] = $attributes['id']; | ||
| $attributes['id'] = $attributes['assetId']; | ||
|
|
||
| $attributes = array_diff_key($attributes, array_flip(array('data', 'fields', 'assetId'))); | ||
|
|
||
| $attributes = array_merge($attributes, $assetData); | ||
|
|
||
| $draft = parent::setAttributes($attributes); | ||
|
|
||
| if ($fieldContent) { | ||
| $post = array(); | ||
|
|
||
| foreach ($fieldContent as $fieldId => $fieldValue) { | ||
| $field = Craft::$app->fields->getFieldById($fieldId); | ||
|
|
||
| if ($field) { | ||
| $post[$field->handle] = $fieldValue; | ||
| } | ||
| } | ||
|
|
||
| $draft->setFieldValues($post); | ||
| } | ||
|
|
||
| return $draft; | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed due to not being in use.
bhupeshappfoster
commented
Apr 5, 2024
| @@ -73,39 +71,6 @@ public function getHandle() | |||
| return $this->getGlobalSet()->handle; | |||
| } | |||
|
|
|||
| public static function populateModel($attributes) | |||
There was a problem hiding this comment.
Not in use
bhupeshappfoster
commented
Apr 5, 2024
| LinkField::class => LinkFieldTranslator::class, | ||
| TypedLinkField::class => TypedLinkFieldTranslator::class, |
There was a problem hiding this comment.
As link field plugin is one renamed to typed link field so removed old one.
bhupeshappfoster
commented
Apr 5, 2024
| case $value instanceof \fruitstudios\linkit\fields\LinkitField: | ||
| case $value instanceof \presseddigital\linkit\fields\LinkitField: |
There was a problem hiding this comment.
Ownership of plugin was changed.
|
The first step for craft 5 upgrade was to resolve issues in plugin code. So we did these changes to fix issues shown by phpstan and now the check is showing this NOTE: I am doing extensive testing to confirm every thing is working as it was prior to these changes. Would be great to have a second pair of eyes too. CC: @MerrittBoydston |
|
Deployed at https://stage.acclarocraft.com/admin/dashboard |
shnsumit
approved these changes
Apr 12, 2024
bhupeshappfoster
added a commit
that referenced
this pull request
Jul 10, 2024
* fixed: code issues before upgrading to craft5 (#499) * updated: change logs and version bumped * Added: hyper link field support (#504) * Bp/524/verbb navigation plugin support (#506) * fixed: activity log table name issue (#505) * fixed: navigration draft and pgsql migration issue * updated: change log * fixed: dashboard UI issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description:
Craft suggested to use php stan before upgrading to craft 5 support and resolve any issues found.
Related Issue(s):
[Cite any related issues or feature requests, using the GitHub issue link.]
Changes Made:
[List the changes made in this pull request to address the issue or implement the feature.]
Added:
Changed:
Deprecated:
Removed:
Fixed:
Security:
Testing:
[Describe the testing performed to ensure the changes are functioning as expected.]
Quality Assurance (QA):
Resources:
Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]
Wrapping up
Checklist:
Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]