Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: hyper link field support #504

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

bhupeshappfoster
Copy link
Collaborator

Pull Request

Description:

[Provide a brief description of the purpose and goal of this pull request.]

Related Issue(s):

[Cite any related issues or feature requests, using the GitHub issue link.]

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its showing updated the file but what we actually did was removed the linkFieldTranslator and created new hyper translator.

@bhupeshappfoster bhupeshappfoster marked this pull request as ready for review May 22, 2024 07:00
@LinneaHarts
Copy link

Thanks for this! Looks like it doesn't work for additional fields attached to hyper fields beyond linkValue and linkText, but it will still be helpful

@bhupeshappfoster bhupeshappfoster merged commit dbec8db into release/3.4.0 Jun 11, 2024
@bhupeshappfoster bhupeshappfoster deleted the BP/Hyper-plugin-support branch June 11, 2024 12:50
bhupeshappfoster added a commit that referenced this pull request Jul 10, 2024
* fixed: code issues before upgrading to craft5 (#499)

* updated: change logs and version bumped

* Added: hyper link field support (#504)

* Bp/524/verbb navigation plugin support (#506)

* fixed: activity log table name issue (#505)

* fixed: navigration draft and pgsql migration issue

* updated: change log

* fixed: dashboard UI issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants