Skip to content

Commit

Permalink
fix: Invalid version of DeployAccount transaction (#202)
Browse files Browse the repository at this point in the history
* set transaction version for deploy account to be hardcoded to 1, because blockifier returns error when using the version that is for fee estimation

* extract transaction version to const
  • Loading branch information
marioiordanov authored Oct 12, 2023
1 parent 110ef1a commit 3c7aba8
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use cairo_felt::Felt252;
use serde::{Deserialize, Serialize};
use starknet_api::core::calculate_contract_address;
use starknet_api::transaction::Fee;
use starknet_rs_ff::FieldElement;

use crate::contract_address::ContractAddress;
use crate::error::DevnetResult;
Expand All @@ -14,6 +15,8 @@ use crate::felt::{
use crate::rpc::transactions::deploy_account_transaction::DeployAccountTransaction;
use crate::rpc::transactions::BroadcastedTransactionCommon;

const TRANSACTION_VERSION: FieldElement = FieldElement::ONE;

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize)]
pub struct BroadcastedDeployAccountTransaction {
#[serde(flatten)]
Expand Down Expand Up @@ -74,7 +77,7 @@ impl BroadcastedDeployAccountTransaction {

let sn_api_transaction = starknet_api::transaction::DeployAccountTransaction {
max_fee: self.common.max_fee,
version: starknet_api::transaction::TransactionVersion(self.common.version.into()),
version: starknet_api::transaction::TransactionVersion(TRANSACTION_VERSION.into()),
signature: starknet_api::transaction::TransactionSignature(
self.common.signature.iter().map(|felt| felt.into()).collect(),
),
Expand Down

0 comments on commit 3c7aba8

Please sign in to comment.