Invalid version of DeployAccount transaction #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimating fee of DeployAccount transactions was failing, because blockifier approves only version 1 for DeployAccount transaction. In our implementation the version that is coming from the BroadcastedTransaction is being used. Which for estimate_fee is offset + transaction version. So the fix is to hardcode the version of deploy account transaction to 1, when creating the starknet_api object.
This error is not present in the other types of transaction, because we are not able to assign value to the transaction version.
Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
cargo test