Remove some TODOs and trigger CI (#201)

0xSpaceShard · Oct 12, 2023 · 110ef1a · 110ef1a
1 parent 13628d9
commit 110ef1a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/crates/starknet-server/src/cli.rs b/crates/starknet-server/src/cli.rs
@@ -102,7 +102,7 @@ impl Args {
                 .try_into()
                 .expect("Invalid value for initial balance"), // TODO: Doesn't exit nicely.
             host: self.host.inner,
-            port: self.port, // TODO: Unification of parsing messages for host and port.
+            port: self.port,
             timeout: self.timeout,
             gas_price: self.gas_price,
             chain_id: match self.chain_id.as_str() {

diff --git a/crates/starknet/src/starknet/mod.rs b/crates/starknet/src/starknet/mod.rs
@@ -333,7 +333,6 @@ impl Starknet {
         Ok(())
     }
 
-    // TODO: rewrite using our BlockId.
     fn get_state_at(&self, block_id: &BlockId) -> DevnetResult<&StarknetState> {
         match block_id {
             BlockId::Tag(_) => Ok(&self.state),
@@ -411,8 +410,6 @@ impl Starknet {
         Ok(res.execution.retdata.0.into_iter().map(Felt::from).collect())
     }
 
-    // TODO: move to estimate_fee file
-    /// Returns just the gas usage, not the overall fee
     pub fn estimate_fee(
         &self,
         block_id: BlockId,

diff --git a/crates/types/src/rpc/contract_class/deprecated/json_contract_class.rs b/crates/types/src/rpc/contract_class/deprecated/json_contract_class.rs
@@ -240,15 +240,6 @@ impl TryFrom<Cairo0Json> for blockifier::execution::contract_class::ContractClas
     }
 }
 
-// TODO: figure out if needed
-// pub fn raw_program_into_json(program: &[u8]) -> DevnetResult<Value> {
-//     let decoder = flate2::read::GzDecoder::new(program);
-//     let starknet_program: LegacyProgram =
-//         serde_json::from_reader(decoder).map_err(JsonError::SerdeJsonError)?;
-//
-//     Ok(serde_json::to_value(starknet_program).map_err(JsonError::SerdeJsonError)?)
-// }
-
 pub fn json_into_raw_program(json_data: &Value) -> DevnetResult<Vec<u8>> {
     let mut buffer = Vec::new();
     let encoder = GzEncoder::new(&mut buffer, Compression::default());

diff --git a/crates/types/src/rpc/transactions/broadcasted_declare_transaction_v1.rs b/crates/types/src/rpc/transactions/broadcasted_declare_transaction_v1.rs
@@ -98,7 +98,6 @@ impl BroadcastedDeclareTransactionV1 {
     ) -> DevnetResult<ClassHash> {
         let additional_data: Vec<Felt252> = vec![self.common.nonce.into()];
         let calldata = vec![class_hash.into()];
-        // TODO: Remove when SirDeclare::new will give same hash
         Ok(calculate_transaction_hash_common(
             SirTransactionHashPrefix::Declare,
             self.common.version.into(),