Remove transfers from phase 0 #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
changed the title
JustinDrake
approved these changes
Oct 24, 2019
|
Nitpick: these comments are confusing:
the "and transfer" parts should be removed in phase 0. Also |
|
When removing complete test files, the test-generator imports/usage also need to be changed. |
|
PR feedback addressed @hwwhww @protolambda |
hwwhww
approved these changes
Oct 24, 2019
3 tasks
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed briefly here -- #1343 -- and in other threads/conversations, the replay protection in the phase 0
Transferfunctionality is far less than perfect and should be reworked before being shipped in any phase.This PR removes Transfers, to be added back in at phase1/2