Remove transfers from phase 0

configs/mainnet.yaml

@@ -116,8 +116,6 @@ MAX_ATTESTATIONS: 128
 MAX_DEPOSITS: 16
 # 2**4 (= 16)
 MAX_VOLUNTARY_EXITS: 16
-# Originally 2**4 (= 16), disabled for now.
-MAX_TRANSFERS: 0
 
 
 # Signature domains
@@ -127,7 +125,6 @@ DOMAIN_BEACON_ATTESTER: 0x01000000
 DOMAIN_RANDAO: 0x02000000
 DOMAIN_DEPOSIT: 0x03000000
 DOMAIN_VOLUNTARY_EXIT: 0x04000000
-DOMAIN_TRANSFER: 0x05000000
 DOMAIN_CUSTODY_BIT_CHALLENGE: 0x06000000
 DOMAIN_SHARD_PROPOSER: 0x80000000
 DOMAIN_SHARD_ATTESTER: 0x81000000

configs/minimal.yaml

@@ -118,8 +118,6 @@ MAX_ATTESTATIONS: 128
 MAX_DEPOSITS: 16
 # 2**4 (= 16)
 MAX_VOLUNTARY_EXITS: 16
-# Originally 2**4 (= 16), disabled for now.
-MAX_TRANSFERS: 0
 
 
 # Signature domains
@@ -129,7 +127,6 @@ DOMAIN_BEACON_ATTESTER: 0x01000000
 DOMAIN_RANDAO: 0x02000000
 DOMAIN_DEPOSIT: 0x03000000
 DOMAIN_VOLUNTARY_EXIT: 0x04000000
-DOMAIN_TRANSFER: 0x05000000
 DOMAIN_CUSTODY_BIT_CHALLENGE: 0x06000000
 DOMAIN_SHARD_PROPOSER: 0x80000000
 DOMAIN_SHARD_ATTESTER: 0x81000000

specs/core/0_beacon-chain.md

@@ -39,7 +39,6 @@
             - [`Attestation`](#attestation)
             - [`Deposit`](#deposit)
             - [`VoluntaryExit`](#voluntaryexit)
-            - [`Transfer`](#transfer)
         - [Beacon blocks](#beacon-blocks)
             - [`BeaconBlockBody`](#beaconblockbody)
             - [`BeaconBlock`](#beaconblock)
@@ -115,7 +114,6 @@
                 - [Attestations](#attestations)
                 - [Deposits](#deposits)
                 - [Voluntary exits](#voluntary-exits)
-                - [Transfers](#transfers)
 
 <!-- /TOC -->
 
@@ -242,7 +240,6 @@ The following values are (non-configurable) constants used throughout the specif
 | `MAX_ATTESTATIONS` | `2**7` (= 128) |
 | `MAX_DEPOSITS` | `2**4` (= 16) |
 | `MAX_VOLUNTARY_EXITS` | `2**4` (= 16) |
-| `MAX_TRANSFERS` | `0` |
 
 ### Domain types
 
@@ -255,7 +252,6 @@ The following types are defined, mapping into `DomainType` (little endian):
 | `DOMAIN_RANDAO` | `2` |
 | `DOMAIN_DEPOSIT` | `3` |
 | `DOMAIN_VOLUNTARY_EXIT` | `4` |
-| `DOMAIN_TRANSFER` | `5` |
 
 ## Containers
 
@@ -289,14 +285,14 @@ class Checkpoint(Container):
 ```python
 class Validator(Container):
     pubkey: BLSPubkey
-    withdrawal_credentials: Hash  # Commitment to pubkey for withdrawals and transfers
+    withdrawal_credentials: Hash  # Commitment to pubkey for withdrawals
     effective_balance: Gwei  # Balance at stake
     slashed: boolean
     # Status epochs
     activation_eligibility_epoch: Epoch  # When criteria for activation were met
     activation_epoch: Epoch
     exit_epoch: Epoch
-    withdrawable_epoch: Epoch  # When validator can withdraw or transfer funds
+    withdrawable_epoch: Epoch  # When validator can withdraw funds
 ```
 
 #### `AttestationData`
@@ -424,19 +420,6 @@ class VoluntaryExit(Container):
     signature: BLSSignature
 ```
 
-#### `Transfer`
-
-```python
-class Transfer(Container):
-    sender: ValidatorIndex
-    recipient: ValidatorIndex
-    amount: Gwei
-    fee: Gwei
-    slot: Slot  # Slot at which transfer must be processed
-    pubkey: BLSPubkey  # Withdrawal pubkey
-    signature: BLSSignature  # Signature checked against withdrawal pubkey
-```
-
 ### Beacon blocks
 
 #### `BeaconBlockBody`
@@ -452,7 +435,6 @@ class BeaconBlockBody(Container):
     attestations: List[Attestation, MAX_ATTESTATIONS]
     deposits: List[Deposit, MAX_DEPOSITS]
     voluntary_exits: List[VoluntaryExit, MAX_VOLUNTARY_EXITS]
-    transfers: List[Transfer, MAX_TRANSFERS]
 ```
 
 #### `BeaconBlock`
@@ -1436,16 +1418,13 @@ def process_eth1_data(state: BeaconState, body: BeaconBlockBody) -> None:
 def process_operations(state: BeaconState, body: BeaconBlockBody) -> None:
     # Verify that outstanding deposits are processed up to the maximum number of deposits
     assert len(body.deposits) == min(MAX_DEPOSITS, state.eth1_data.deposit_count - state.eth1_deposit_index)
-    # Verify that there are no duplicate transfers
-    assert len(body.transfers) == len(set(body.transfers))
 
     for operations, function in (
         (body.proposer_slashings, process_proposer_slashing),
         (body.attester_slashings, process_attester_slashing),
         (body.attestations, process_attestation),
         (body.deposits, process_deposit),
         (body.voluntary_exits, process_voluntary_exit),
-        (body.transfers, process_transfer),
         # @process_shard_receipt_proofs
     ):
         for operation in operations:
@@ -1584,33 +1563,3 @@ def process_voluntary_exit(state: BeaconState, exit: VoluntaryExit) -> None:
     # Initiate exit
     initiate_validator_exit(state, exit.validator_index)
 ```
-
-##### Transfers
-
-```python
-def process_transfer(state: BeaconState, transfer: Transfer) -> None:
-    # Verify the balance the covers amount and fee (with overflow protection)
-    assert state.balances[transfer.sender] >= max(transfer.amount + transfer.fee, transfer.amount, transfer.fee)
-    # A transfer is valid in only one slot
-    assert state.slot == transfer.slot
-    # Sender must satisfy at least one of the following:
-    assert (
-        # 1) Never have been eligible for activation
-        state.validators[transfer.sender].activation_eligibility_epoch == FAR_FUTURE_EPOCH or
-        # 2) Be withdrawable
-        get_current_epoch(state) >= state.validators[transfer.sender].withdrawable_epoch or
-        # 3) Have a balance of at least MAX_EFFECTIVE_BALANCE after the transfer
-        state.balances[transfer.sender] >= transfer.amount + transfer.fee + MAX_EFFECTIVE_BALANCE
-    )
-    # Verify that the pubkey is valid
-    assert state.validators[transfer.sender].withdrawal_credentials == BLS_WITHDRAWAL_PREFIX + hash(transfer.pubkey)[1:]
-    # Verify that the signature is valid
-    assert bls_verify(transfer.pubkey, signing_root(transfer), transfer.signature, get_domain(state, DOMAIN_TRANSFER))
-    # Process the transfer
-    decrease_balance(state, transfer.sender, transfer.amount + transfer.fee)
-    increase_balance(state, transfer.recipient, transfer.amount)
-    increase_balance(state, get_beacon_proposer_index(state), transfer.fee)
-    # Verify balances are not dust
-    assert not (0 < state.balances[transfer.sender] < MIN_DEPOSIT_AMOUNT)
-    assert not (0 < state.balances[transfer.recipient] < MIN_DEPOSIT_AMOUNT)
-```

specs/test_formats/operations/README.md

@@ -46,7 +46,6 @@ Operations:
 | `block_header`          | `Block`              | **`block`**          | `process_block_header(state, block)`                   |
 | `deposit`               | `Deposit`            | `deposit`            | `process_deposit(state, deposit)`                      |
 | `proposer_slashing`     | `ProposerSlashing`   | `proposer_slashing`  | `process_proposer_slashing(state, proposer_slashing)`  |
-| `transfer`              | `Transfer`           | `transfer`           | `process_transfer(state, transfer)`                    |
 | `voluntary_exit`        | `VoluntaryExit`      | `voluntary_exit`     | `process_voluntary_exit(state, voluntary_exit)`        |
 
 Note that `block_header` is not strictly an operation (and is a full `Block`), but processed in the same manner, and hence included here.

test_generators/operations/main.py

@@ -6,7 +6,6 @@
     test_process_block_header,
     test_process_deposit,
     test_process_proposer_slashing,
-    test_process_transfer,
     test_process_voluntary_exit,
 )
 
@@ -48,10 +47,6 @@ def cases_fn() -> Iterable[gen_typing.TestCase]:
         create_provider('deposit', test_process_deposit, 'mainnet'),
         create_provider('proposer_slashing', test_process_proposer_slashing, 'minimal'),
         create_provider('proposer_slashing', test_process_proposer_slashing, 'mainnet'),
-        create_provider('transfer', test_process_transfer, 'minimal'),
-        # Disabled, due to the high amount of different transfer tests, this produces a shocking size of tests.
-        # Unnecessarily, as transfer are disabled currently, so not a priority.
-        # create_provider('transfer', test_process_transfer, 'mainnet'),
         create_provider('voluntary_exit', test_process_voluntary_exit, 'minimal'),
         create_provider('voluntary_exit', test_process_voluntary_exit, 'mainnet'),
     ])