Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for dubbo-registry/dubbo-registry-api #2177

Closed
chickenlj opened this issue Aug 3, 2018 · 1 comment
Closed

Unit Test for dubbo-registry/dubbo-registry-api #2177

chickenlj opened this issue Aug 3, 2018 · 1 comment
Labels
help wanted Everything needs help from contributors

Comments

@chickenlj
Copy link
Contributor

Sub-task of #1690
@chickenlj
Copy link
Contributor Author

chickenlj commented Aug 3, 2018 •
edited
Loading

The following branches are in need of UT:

  • org.apache.dubbo.registry.support.AbstractRegistry#register
  • org.apache.dubbo.registry.support.AbstractRegistry#unregister
  • org.apache.dubbo.registry.support.AbstractRegistry#subscribe
  • org.apache.dubbo.registry.support.AbstractRegistry#unsubscribe
  • org.apache.dubbo.registry.support.AbstractRegistry#recover
  • org.apache.dubbo.registry.support.AbstractRegistry#notify(java.util.List<org.apache.dubbo.common.URL>)
  • org.apache.dubbo.registry.support.AbstractRegistry#notify(org.apache.dubbo.common.URL, org.apache.dubbo.registry.NotifyListener, java.util.List<org.apache.dubbo.common.URL>)

The better the higher of the code coverage. But remember code coverage is not the only standard, A reasonable Test Case is also very important.

@chickenlj chickenlj added help wanted Everything needs help from contributors good first issue labels Aug 3, 2018
MasterHJG added a commit to MasterHJG/incubator-dubbo that referenced this issue Aug 7, 2018
@MasterHJG
增加AbstractRegistry测试用例
9e7137d 
Unit Test for dubbo-registry/dubbo-registry-api apache#2177
MasterHJG added a commit to MasterHJG/incubator-dubbo that referenced this issue Aug 7, 2018
@MasterHJG
增加AbstractRegistry测试用例
e5eed38 
Unit Test for dubbo-registry/dubbo-registry-api apache#2177
@MasterHJG MasterHJG mentioned this issue Aug 7, 2018
Closed
6 tasks
@shenpeilin shenpeilin mentioned this issue Aug 7, 2018
Closed
6 tasks
@KDD-HIEPT KDD-HIEPT mentioned this issue Aug 7, 2018
Merged
zhinieing added a commit to zhinieing/incubator-dubbo that referenced this issue Aug 13, 2018
@zhinieing
issues apache#2177
000177c
@ywtdzh ywtdzh mentioned this issue Aug 13, 2018
Closed
6 tasks
@Defined2014 Defined2014 mentioned this issue Aug 14, 2018
Closed
3 tasks
@lhjlhj13141314 lhjlhj13141314 mentioned this issue Aug 14, 2018
Merged
6 tasks
@zhinieing zhinieing mentioned this issue Aug 14, 2018
Merged
1 task
@Beckyyala Beckyyala mentioned this issue Aug 14, 2018
Closed
6 tasks
@binss binss mentioned this issue Aug 14, 2018
Merged
6 tasks
@thinkerleolee thinkerleolee mentioned this issue Aug 14, 2018
Closed
6 tasks
beiwei30 pushed a commit that referenced this issue Aug 15, 2018
@binss @beiwei30
[Dubbo-#2177] Improve and Add Unit Test for org.apache.dubbo.registry…
049591f 
….support.AbstractRegistry #2177 Team2 (#2284)

* Fix format problem of AbstractRegistryTest

* Improve existing tests and add multi thread tests
beiwei30 pushed a commit that referenced this issue Aug 15, 2018
@zhinieing @beiwei30
Baiji 269 team 9 add unit test (#2261)
92c566a 
* issues #2177

* issues #217 modifed
beiwei30 pushed a commit that referenced this issue Aug 15, 2018
@lhjlhj13141314 @beiwei30
[Dubbo-2177]Fix the issue: Supplementary unit test #2177 team 3 (#2260)
f364a44 
* test

* Please enter the commit message for your changes. Lines starting

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Everything needs help from contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supplementary unit test #2177 team6 thinkerleolee/incubator-dubbo
2 participants
@diecui1202 @chickenlj