Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-#2177] Improve unit test for AbstractRegistry team1 #2257

Closed
wants to merge 1 commit into from
Closed

[Dubbo-#2177] Improve unit test for AbstractRegistry team1 #2257

wants to merge 1 commit into from

Conversation

Defined2014
Copy link

Improve unit test with better coverage for org.apache.dubbo.registry.support.AbstractRegistry

Run the unit test file dubbo-registry/dubbo-registry-api/src/test/java/org.apache.dubbo.registry.support/AbstractRegistryTest.java.

From Baiji, Term 269, Team 1, Issue #2177, Q2

What is the purpose of the change

Enhancement coverage for AbstractRegistry UT

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

@Defined2014 Defined2014 changed the title [Dubbo-#2177] Improve unit test with better coverage for AbstractRegistry #2177 [Dubbo-#2177] Improve unit test with better coverage for AbstractRegistry team1 Aug 14, 2018
@Defined2014 Defined2014 changed the title [Dubbo-#2177] Improve unit test with better coverage for AbstractRegistry team1 [Dubbo-#2177] Improve unit test for AbstractRegistry team1 Aug 14, 2018
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #2257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2257   +/-   ##
=========================================
  Coverage     54.57%   54.57%           
- Complexity     5156     5157    +1     
=========================================
  Files           568      568           
  Lines         25019    25019           
  Branches       4456     4456           
=========================================
  Hits          13655    13655           
+ Misses         9323     9321    -2     
- Partials       2041     2043    +2
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 50.7% <0%> (-0.71%) 43% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 53.55% <0%> (+1.49%) 47% <0%> (+4%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.71% <0%> (+10.71%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16f78...78139ad. Read the comment docs.

Improve unit test with better coverage for org.apache.dubbo.registry.support.AbstractRegistry

Run the unit test file `dubbo-registry/dubbo-registry-api/src/test/java/org.apache.dubbo.registry.support/AbstractRegistryTest.java`.

From Baiji, Term 269, Team 1, Issue #2177, Q2
@beiwei30 beiwei30 closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants