Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplementary unit test #2177 team6 #2288

Closed
wants to merge 13 commits into from

Conversation

thinkerleolee
Copy link

@thinkerleolee thinkerleolee commented Aug 14, 2018

What is the purpose of the change

Resolve #2177.

Brief changelog

The following branches have been Unit Tested:
org.apache.dubbo.registry.support.AbstractRegistry#notify
org.apache.dubbo.registry.support.AbstractRegistry#lookup
org.apache.dubbo.registry.support.AbstractRegistry#getCacheUrl
org.apache.dubbo.registry.support.AbstractRegistry#toString
org.apache.dubbo.registry.support.AbstractRegistry#getCacheFile
org.apache.dubbo.registry.support.AbstractRegistry#getCacheProperties
org.apache.dubbo.registry.support.AbstractRegistry#getLastCacheChange
org.apache.dubbo.registry.support.AbstractRegistry#filterEmpty
org.apache.dubbo.registry.support.AbstractRegistry#setUrl
org.apache.dubbo.registry.support.AbstractRegistry#destory

BaiJi training camp 269 Team No.6, Alibaba-Inc.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test for dubbo-registry/dubbo-registry-api
3 participants