Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2177]modified abstract-registry-test Team 8 #2263

Closed

Conversation

Beckyyala
Copy link

@Beckyyala Beckyyala commented Aug 14, 2018

What is the purpose of the change

improve unit test for some method in abstract-registry
fix issue #2177 baji Team 8

Brief changelog

check initializing with empty url
add after method destroy()
check unregister empty url
check empty url in notify

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

check initializing with empty url
add after method destroy()
check unregister empty url
check empty url in notify
@diecui1202 diecui1202 changed the title modified abstract-registry-test modified abstract-registry-test Team 8 Aug 14, 2018
@Beckyyala Beckyyala changed the title modified abstract-registry-test Team 8 [Dubbo-2177]modified abstract-registry-test Team 8 Aug 14, 2018
@beiwei30 beiwei30 closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants