[DO NOT MERGE]: accessibility docs #4754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rmanole <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
* chore: updated changelog manually to remove duplicates * chore: added changelog entries for bug fixes from interaction controller * chore: updated changelog items for action menu and picker * chore: updated changelog for picker --------- Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TaraT <[email protected]>
* fix(toast): added ability to wrap toast content with long words * ci: updated golden image cache --------- Co-authored-by: Rajdeep Chandra <[email protected]>
* feat(breadcrumbs): breadcrumbs component * chore: remove duplicated CSS, some optional dependencies and add aria-label * chore: accessibility * chore: stories * chore(breadcrumbs): wip breadcrumbs * chore: prototype minimal viable product * chore: more cleanup * chore: unit tests * chore: update stories * chore: update stories and docs * chore: unit tests & golden image cache * chore: process spectrum-css for sp-breadcrumb-item * chore: golden image cache * chore: added compact and disabled state * chore: added breadcrumbs documentation * chore: added disabled property * chore: process spectrum-css for compact * chore: golden image cache * chore: partially addressing code review * chore: address remaining code review comments * chore: golden image cache * chore: enabled tab index for last item * chore: updated breadcrumbs css version to 9.1.3 * chore: golden image cache * chore: adds docs section for Breadcrumb item & hide internal properties * chore: fix typo --------- Co-authored-by: abaicu <[email protected]> Co-authored-by: rmanole <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TaraT <[email protected]>
* chore(progress-bar): upgrade progress-bar and meter css --------- Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
* fix(toast): added ability to wrap toast content with long words * ci: updated golden image cache --------- Co-authored-by: Rajdeep Chandra <[email protected]>
…ponents into nikkimk/accessibility-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving the accessibility documentation of components.
Related issue(s)
Motivation and context
Documentation should provide more information and examples that demonstrate how to use the components accessibly.
How has this been tested?
<sp-picker><sp-menu><sp-help-text><sp-button><sp-button-group><sp-action-button><sp-action-bar><sp-action-group><sp-action-menu>Are the examples accessible?
Do the docs examples and text provide information on how to use the component accessibly?
If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
Are the docs headings logical and consistent across these components?
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.