Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update chrome driver for tachometer tests #4716

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Sep 2, 2024

Description

update chrome driver for tachometer tests

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

github-actions bot commented Sep 2, 2024

Branch preview

Copy link

github-actions bot commented Sep 2, 2024

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 10670104560

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.199%

Totals Coverage Status
Change from base Build 10670059124: 0.0%
Covered Lines: 32500
Relevant Lines: 32931

💛 - Coveralls

@Rajdeepc Rajdeepc marked this pull request as ready for review September 2, 2024 15:45
@Rajdeepc Rajdeepc requested a review from a team as a code owner September 2, 2024 15:45
Copy link

github-actions bot commented Sep 2, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 225.921 kB 214.469 kB 214.449 kB 🏆
Scripts 55.454 kB 49.863 kB 49.776 kB 🏆
Stylesheet 34.521 kB 30.181 kB 🏆 30.258 kB
Document 6.194 kB 5.446 kB 5.442 kB 🏆
Font 126.775 kB 126.597 kB 🏆 126.623 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@Rajdeepc Rajdeepc merged commit f4df058 into main Sep 2, 2024
61 checks passed
@Rajdeepc Rajdeepc deleted the fix/chromedriver branch September 2, 2024 16:16
nikkimk pushed a commit that referenced this pull request Sep 13, 2024
nikkimk pushed a commit that referenced this pull request Sep 13, 2024
nikkimk pushed a commit that referenced this pull request Sep 13, 2024
nikkimk pushed a commit that referenced this pull request Sep 13, 2024
nikkimk pushed a commit that referenced this pull request Sep 13, 2024
nikkimk pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants