Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contextual-help): export typings #4655

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(contextual-help): export typings #4655

merged 1 commit into from
Aug 7, 2024

Conversation

Rocss
Copy link
Contributor

@Rocss Rocss commented Aug 7, 2024

Description

Missing Contextual Help from tsconfig-all.json, therefore types are not being published with the package.

Related issue(s)

Motivation and context

see #4648

How has this been tested?

  • Test case 1

    1. In this repo run yarn install
    2. Check out node_modules/spectrum-web-components/contextual-help
    3. See that sp-contextual-help.d.ts exists.
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

github-actions bot commented Aug 7, 2024

Branch preview

Copy link

github-actions bot commented Aug 7, 2024

Tachometer results

Currently, no packages are changed by this PR...

@Rocss Rocss marked this pull request as ready for review August 7, 2024 08:45
@Rocss Rocss requested a review from a team as a code owner August 7, 2024 08:45
@Rajdeepc Rajdeepc merged commit 8febc38 into main Aug 7, 2024
57 of 58 checks passed
@Rajdeepc Rajdeepc deleted the rocss/4648 branch August 7, 2024 10:07
nikkimk pushed a commit that referenced this pull request Aug 7, 2024
TarunAdobe pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants