Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.5.2 #465

Closed
wants to merge 7 commits into from
Closed

Release/1.5.2 #465

wants to merge 7 commits into from

Conversation

buranmert
Copy link
Contributor

@buranmert buranmert commented Apr 12, 2021 •
edited
Loading

Fix 1: #450
Fix 2: #451
Feature (intended for internal use only): #459

Note: This PR cannot be merged to master, this commit will be shipped once this PR is approved

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Ensure dd-bridge-ios works with this version

ncreated and others added 2 commits April 12, 2021 14:11
@ncreated @buranmert
Merge pull request #453 from DataDog/ncreated/RUMM-1222-fix-linter-ve…
4ca9942 
…rsion-on-CI

RUMM-1222 Update to swiftlint `0.43.x`
@buranmert
Merge pull request #454 from DataDog/ncreated/RUMM-1222-enforce-up-to…
d14b458 
…-date-version-of-swiftlint

RUMM-1222 Patch configuration for `swiftlint 0.42.0`
@buranmert buranmert self-assigned this Apr 12, 2021
@buranmert buranmert force-pushed the release/1.5.2 branch 5 times, most recently from 60ae105 to eb46826 Compare April 12, 2021 14:39
@buranmert buranmert marked this pull request as ready for review April 12, 2021 14:44
@buranmert buranmert requested a review from a team as a code owner April 12, 2021 14:44
@buranmert buranmert marked this pull request as draft April 12, 2021 15:04
@buranmert
Merge pull request #451 from DataDog/buranmert/RUMM-1160-support-stat…
8df6aa8 
…ic-pod

RUMM-1160 Static pod support
@buranmert
Merge pull request #456 from DataDog/xgouchet/RUMM-1213/additional_co…
a4b099e 
…nfiguration

RUMM-1213 Allow additional configuration when initializing the SDK
@buranmert
Merge pull request #459 from DataDog/xgouchet/RUMM-1038/update_source
810f221 
RUMM-1038 add option to customize the `source` tag
@buranmert buranmert force-pushed the release/1.5.2 branch 2 times, most recently from e1e529e to 201305a Compare April 12, 2021 16:46
@buranmert
Copy link
Contributor Author

dd-bridge-ios/Example app tested without use_frameworks! with Datadog 1.5.2 ✅

pod install
Analyzing dependencies
Pre-downloading: `DatadogSDK` from `https://github.com/DataDog/dd-sdk-ios.git`, branch `release/1.5.2`
Downloading dependencies
Installing DatadogSDK (1.5.2)
Installing DatadogSDKBridge (0.2.0)
Installing Kronos (4.2.1)
Generating Pods project
Integrating client project
Pod installation complete! There are 3 dependencies from the Podfile and 3 total pods installed.

@buranmert buranmert marked this pull request as ready for review April 12, 2021 18:47
ncreated
ncreated requested changes Apr 13, 2021
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release branche must be merged to master, otherwise our git flow would be desynchronised. If it's not possible due to CI flakiness, let's have that one fixed first: I tried to tackle it in #468

@ncreated ncreated closed this Apr 13, 2021
@ncreated ncreated deleted the release/1.5.2 branch April 13, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated requested changes

Assignees

@buranmert buranmert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buranmert @ncreated