RUMM-1213 Allow additional configuration when initializing the SDK #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
requested changes
Mar 31, 2021
| @@ -277,6 +277,11 @@ public class DDConfigurationBuilder: NSObject { | |||
| _ = sdkBuilder.set(uploadFrequency: uploadFrequency.swiftType) | |||
| } | |||
|
|
|||
| @objc | |||
| public func set(additionalConfiguration: [String: Any]) { | |||
| _ = sdkBuilder.set(additionalConfiguration: castAttributesToSwift(additionalConfiguration)) | |||
There was a problem hiding this comment.
We shouldn't and we can't use castAttributesToSwift() in this case. The castAttributesToSwift() wraps Any value into AnyEncodable wrapper - so it changes its identity. That said, if we pass "_dd.foo": "bar" from Obj-c, the downstream assumption in Swift SDK will fail:
// This will fail, as `additionalConfigurations["_dd.foo"]` is `AnyEncodable`, not `String`:
let bar = additionalConfigurations["_dd.foo"] as? StringInstead, we should just pass the additionalConfiguration as it is:
_ = sdkBuilder.set(additionalConfiguration: additionalConfiguration)so the above assumption can pass.
The castAttributesToSwift() is only used for capturing serializable values (log / span / rum attributes). In their case, we don't make the as? assumption on their identity - we just encode them using encoding implementation from AnyEncodable.
buranmert
added a commit
that referenced
this pull request
Apr 12, 2021
…nfiguration RUMM-1213 Allow additional configuration when initializing the SDK
buranmert
added a commit
that referenced
this pull request
Apr 12, 2021
…nfiguration RUMM-1213 Allow additional configuration when initializing the SDK
ncreated
pushed a commit
that referenced
this pull request
Apr 13, 2021
…nfiguration RUMM-1213 Allow additional configuration when initializing the SDK (cherry picked from commit 8eb7385)
ncreated
pushed a commit
that referenced
this pull request
Apr 13, 2021
…nfiguration RUMM-1213 Allow additional configuration when initializing the SDK (cherry picked from commit 8eb7385)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Let customer set additional configuration as a Dictionary. This will be used to configure internal settings of the SDK