Allow preset values to be configured

[scott-the-programmer]

Allow preset values to be configured

Modifying preset values such as maxDirectorySize and maxFileAgeForRead would be useful for clients to be able to tailor to their specific use case.

Personally, I think the cleanest way might be to allow leverage set(additionalConfiguration) introduced by #456 and propagate that down to PerformancePreset

Datadog.Configuration
       .set(additionalConfiguration: ["performance": ["maxDirectorySize": 512 * 1_024 * 1_024]])

Keen to know everyone else's thoughts!

[buranmert]

hi @scott-the-programmer

can you tell us more about your use case?

[scott-the-programmer]

The main reason would be to provide an absolute limit on the logs accumulated before trackingConsent is acknowledged. From the looks of it, this could be covered by setting maxDirectorySize.

In the absolute worst case, while trackingConsent is pending, verbose logging could store up to 512mb of logs that could potentially be shipped to datadog in a relatively short period of time.

[buranmert]

in order to avoid such cases, we do upload file by file; so the upper bound of an upload should be maxFileSize (which is by default 4Mb). if you have 512Mb of logs collected, it should be uploaded in roughly 512 / ~4 = ~128 batches and the interval between two uploads is on average 5 seconds (128 * 5 seconds = ~10.6 minutes).

you can play with batch size and upload frequency parameters to change the values above.

also, since we use iOS' Caches folder and logs collected at .pending mode are not carried over to the next app launch (they are discarded), having 512Mb of logs is really the absolute worst case as you said.

please let me know if your concerns are addressed; if not, we can try to find a solution 🤞

[buranmert]

i'm hoping the concern is addressed and closing the issue.
feel free to reopen if needed.