RUMM-1222 Patch configuration for swiftlint 0.42.0
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CARTHAGE flag is set for xcodebuild, build phase is skipped
ncreated
force-pushed
the
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
branch
from
ad8de53 to
991b20f
Compare
ncreated
force-pushed
the
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
branch
from
3afba1d to
b64c443
Compare
ncreated
changed the title
swiftlint 0.42.0
ncreated
force-pushed
the
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
branch
from
b64c443 to
c07eed6
Compare
…r-carthage RUMM-1204 Linter not run for carthage builds
buranmert
reviewed
Mar 30, 2021
buranmert
approved these changes
Mar 30, 2021
ncreated
deleted the
ncreated/RUMM-1222-enforce-up-to-date-version-of-swiftlint
branch
buranmert
added a commit
that referenced
this pull request
Apr 12, 2021
…-date-version-of-swiftlint RUMM-1222 Patch configuration for `swiftlint 0.42.0`
ncreated
added a commit
that referenced
this pull request
Apr 13, 2021
…-date-version-of-swiftlint (cherry picked from commit 338ab8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 Appears that depending on the Bitrise agent version,
brew install swiftlintresolves to either recent0.43.1or0.42.0. Because there is a breaking change in configuration between the two (addressed in #453), we need to patch theswiftlint.ymlfor0.42.0.I've opened a support ticket to Bitrise team to check this inconsistency, but it might be caused by the
brew-coremirror created by Bitrise, more here: https://discuss.bitrise.io/t/how-to-change-brew-core-from-mirror-to-official/16033How?
If the runner uses
0.42.0we apply the patch, otherwise not.The patch updates linter paths by removing
../..added in #453.Review checklist