feat(board): add boards #2
Conversation
|
I'll check this once #1 would be merged |
WikiRik
force-pushed
the
mvp-boards
branch
2 times, most recently
from
e3b32fd to
f0237fe
Compare
|
Not sure if I've copied the api-requests test correctly (@serge1peshcoff can you check) and as mentioned above it's still missing tests, but should be enough for @LeonVreling to work further on it. |
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage ? 98.14%
=======================================
Files ? 13
Lines ? 270
Branches ? 44
=======================================
Hits ? 265
Misses ? 5
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Okay, fixed the test. Took me a bit longer than I wanted but in the end I figured it out. @LeonVreling do you feel like making the rest of the tests when you are implementing the other board change features? https://myaegee.atlassian.net/browse/MA-141 has a list of tests that I've thought of already |
|
@LeonVreling will add more tests and do the rest of the implementation in another PR |
WikiRik
requested review from
serge1peshcoff
and removed request for
serge1peshcoff
|
@serge1peshcoff could you take a look at this? |
|
@LeonVreling how much do you still want to add in this PR? I would like to update CircleCI and Node here as well but I would like to merge this first |
|
Some things are broken after the addition of mailer. One thing that needs to be added (and hopefully fixes brokenness) is the input validation |
Tests are still missing
WikiRik
requested review from
LeonVreling,
serge1peshcoff and
a team
and removed request for
serge1peshcoff and
LeonVreling
# [1.1.0](1.0.0...1.1.0) (2022-09-18) ### Features * **board:** add boards ([#2](#2)) ([e7385eb](e7385eb))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Tests are still missing