chore(skeleton): files only refactored from discounts #1
Conversation
|
@serge1peshcoff I will rebase #2 after you've approved this so it's more clear there what I've changed |
| which node && node -v | ||
| - run: npm install | ||
| - run: npx semantic-release | ||
| - run: docker build --tag aegee/network:$(node -p "require('./package.json').version") --tag aegee/network:latest -f ./docker/network/Dockerfile . |
There was a problem hiding this comment.
for this to work on CI, you'll need to set env variables for docker login, github token and slack token for notifications, and also give aegeedeployer permission to push to aegee/network.
There was a problem hiding this comment.
Can you do this for me? I don't have the permissions/information to do this
| - "traefik.backend=network" | ||
| - "traefik.port=8084" | ||
| - "traefik.auth.frontend.rule=PathPrefix:/api/network/metrics;PathPrefixStrip:/api/network;" | ||
| - "traefik.new.frontend.rule=PathPrefixStrip:/api/network;" |
There was a problem hiding this comment.
maybe it makes sense to rename it to something like "all" or "general", as we don't have "old" anymore (/services/oms-network/api
There was a problem hiding this comment.
I tried to just not mention it at all but that broke Traefik, I'll just leave new here until we refactor it for all modules
There was a problem hiding this comment.
not mentioning it will not work, I assume because it will just apply this rule to all frontends (including auth)
| ENV PATH="/home/node/.npm-global/bin:${PATH}" | ||
|
|
||
| RUN npm install -g --loglevel warn nodemon bunyan && npm cache clean --force | ||
| RUN npm install --loglevel warn |
There was a problem hiding this comment.
check out this thread: https://myaegee.slack.com/archives/C45Q9DTMK/p1603991345073800, maybe we can make it nice from the start
There was a problem hiding this comment.
FROM node:12
RUN mkdir -p /usr/app/src \
&& mkdir -p /usr/app/media \
&& mkdir -p /usr/app/scripts
COPY --chown=node:node package.json /usr/app/src
ENV NPM_CONFIG_PREFIX=/home/node/.npm-global
ENV PATH="/home/node/.npm-global/bin:${PATH}"
RUN npm install -g --loglevel warn nodemon bunyan && npm cache clean --force
RUN npm install --loglevel warn
COPY . /usr/app/src
RUN chown -R node:node /usr/app
USER node
COPY ./docker/network/bootstrap.sh /usr/app/scripts/bootstrap.sh
CMD sh /usr/app/scripts/bootstrap.sh && npm start
EXPOSE 8084
Like this?
There was a problem hiding this comment.
@linuxbandit you might also be interested in this
There was a problem hiding this comment.
this should do it I think
There was a problem hiding this comment.
yes, I'll add some touches later as this is merged already but it is good overall
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Not a working system, but these files should only be refactored stuff. Still would be nice if you could take a small look at it