Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): add board change #862

Merged
merged 24 commits into from
Sep 26, 2023
Merged

feat(network): add board change #862

merged 24 commits into from
Sep 26, 2023

Conversation

LeonVreling
Copy link
Member

@LeonVreling LeonVreling commented Feb 7, 2021 •
edited by jira bot
Loading

Implementes MA-140 (hopefully)

@LeonVreling
Copy link
Member Author

LeonVreling commented Feb 11, 2021 •
edited
Loading

Maybe a good idea to mention that all of this builds on AEGEE/network#2

WikiRik
WikiRik reviewed Feb 11, 2021
View reviewed changes
@WikiRik WikiRik changed the title Add frontend board change feat(network): add board change Mar 13, 2021
@LeonVreling LeonVreling requested a review from WikiRik March 20, 2021 22:39
WikiRik
WikiRik reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good already, nice work!

@LeonVreling LeonVreling mentioned this pull request Mar 21, 2021
Merged
@WikiRik WikiRik force-pushed the add-board-change branch from f6760f9 to 24e95cd Compare June 2, 2021 12:06
@LeonVreling @WikiRik
feat(body): add frontend board change
83fb34e
@LeonVreling @WikiRik
feat(board): integrate backend board change
bc7c19a
@LeonVreling @WikiRik
feat(board): display current board on body page
4bdbce9
@LeonVreling @WikiRik
feat(board): add and display more functions
9fb7c36
@LeonVreling @WikiRik
feat(board): prompt contact details on board change
abecf9d
@LeonVreling @WikiRik
feat(board): add current board overview page
febdbb5
@LeonVreling @WikiRik
fix(boards): display everything when no filter body type
68ac79d
@LeonVreling @WikiRik
fix(board): do not display error on cancel token boardlist
b28c93c
@LeonVreling @WikiRik
chore(board): add update postal address board change
cc91d63
@LeonVreling @WikiRik
chore(wip): restarting everything :(
7739047
@LeonVreling @WikiRik
fix(board): fix random stuff
02447cf
@LeonVreling @WikiRik
chore(board): fix lint
6ab2638
@LeonVreling @WikiRik
chore(board): oops
be492be
@LeonVreling @WikiRik
chore(board): remove unnecessary extra style
cc6f2b9
@LeonVreling @WikiRik
chore(board): oops^2
e712b73
@LeonVreling @WikiRik
chore(board): ugh
0149da2
@LeonVreling @WikiRik
chore(boards): now everything should really work
dc40ca5
@LeonVreling @WikiRik
feat(board): add name board
64afc7f
@WikiRik WikiRik marked this pull request as ready for review December 1, 2021 16:28
@WikiRik
Copy link
Member

WikiRik commented Dec 1, 2021

@serge1peshcoff this is working now so after the final tests of Network Director/NetCom we can merge this and publish the first thing of the network module

@WikiRik
Copy link
Member

WikiRik commented Dec 1, 2021

This is of course merged with AEGEE/network#2 and AEGEE/mailer#65

@LeonVreling
Copy link
Member Author

@WikiRik do you maybe know what the status of this PR is?

@WikiRik
Copy link
Member

WikiRik commented May 28, 2023

We need to rebase and retest but I think this is ready to be merged apart from that

WikiRik
WikiRik approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this in, without the manage_network:boards or view:board permissions nobody should see this

@WikiRik WikiRik merged commit 32e44a9 into stable Sep 26, 2023
@WikiRik WikiRik deleted the add-board-change branch September 26, 2023 14:51
serge1peshcoff pushed a commit that referenced this pull request Sep 26, 2023
@semantic-release-bot
chore(release): 1.34.0 [skip ci]
120c080 
# [1.34.0](1.33.37...1.34.0) (2023-09-26)

### Features

* **network:** add board change ([#862](#862)) ([32e44a9](32e44a9))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@LeonVreling LeonVreling mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@serge1peshcoff serge1peshcoff Awaiting requested review from serge1peshcoff

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeonVreling @WikiRik @serge1peshcoff