New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catching an exception from the move constructor destroys the original data #5

Closed

zrax opened this issue Feb 2, 2017 · 1 comment

Owner

zrax commented Feb 2, 2017

Discovered while working on a fix for H-uru/libhsplasma#97:

ST::string foo;
ST::char_buffer init = {...};
try {
    foo = init;
} catch (ST::unicode_error &) {
    // init is now empty due to move constructor
}

Owner Author

zrax commented Feb 2, 2017

Fixed with 5c774d2, to be included in 1.5

zrax closed this as completed

zrax added a commit that referenced this issue


          Add regression test for #5

2caadc8

momoko-h mentioned this issue

Heap buffer overflow when using ST::string::replace #29

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment