Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to string_theory regressed opening some prp files #97

Closed
diafero opened this issue Feb 1, 2017 · 5 comments
Closed

Port to string_theory regressed opening some prp files #97

diafero opened this issue Feb 1, 2017 · 5 comments
Assignees

Comments

@diafero
Copy link
Member

diafero commented Feb 1, 2017

Attached is an example of a prp file that used to open fine with older versions of libhsplasma, that works fine with Uru, but that does not work with current master. The error shown by PrpShop says something about invalid UTF-8, so I assume this is related to the recent move to a different string processing library.

Elodea_District_beach.prp.tar.gz

@diafero
Copy link
Member Author

diafero commented Feb 1, 2017

The issue is probably caused by an object (a texture, more specifically) having a name that's not valid UTF-8: Holz alt f�r Balk.004.
(I guess this is the German umlaut ü encoded in ISO-8859-1 or a similar encoding.)

@Hoikas
Copy link
Member

Hoikas commented Feb 2, 2017

I noticed that a different blend file produced by Dulcamara included textures with latin_1 encoded ü characters. This actually made Blender 2.7x crash! IMO the bug is on the end user's side for creating defective files, but I'll defer to @zrax.

@Deledrius
Copy link
Member

Deledrius commented Feb 2, 2017

Calling the file 'defective' is a bit harsh. That's an input problem on the part of Blender for not converting the encoding to what it needs/expects.

@diafero
Copy link
Member Author

diafero commented Feb 2, 2017

Well, the point is, the file works just fine in Blender and Uru. My dataserver generation scripts load the PRP files via libhsplasma to make some sanity checks (e.g. to make sure there are no horribly broken plLinkResponders in there), and thus dataserver generation fails with libhsplasma master. The way things are right now, I have the choice between asking Dulcamara (and others using umlauts in filenames and object names) to rename some things in order to fix issues they can't see, or alternatively forever sticking to an older version of libhsplasma. I don't think the first first solution would be appropriate; after all, the files are working perfectly fine, so there's no fundamental reason anything needs to be changed. Many age writers are not very tech-savvy, and I don't even know how hard it is to rename things and fix every reference in Blender. Ultimately, the issue only exists on my side, in the toolchain I use, which (somewhat arbitrarily) places more restrictions on the validity of PRP files than Uru does. Even though I agree it would be nice to have everything be valid UTF-8, I feel it is wrong to put the burden of this decision onto age writers. It's not like we have too many of them...
(Considering the age of Uru:TPOTS, I would actually be surprised if it does use UTF-8, but I don't know.)

@Deledrius
Copy link
Member

Deledrius commented Feb 3, 2017

@diafero, do your automated checks function properly with #98 applied?

@zrax zrax closed this as completed in 65fdff5 Feb 9, 2017
Hoikas pushed a commit to Hoikas/libhsplasma that referenced this issue Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants