Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

229 icons for resources and grouped regions #230

Merged
merged 8 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vsce/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the "cics-extension-for-zowe" extension will be documented in this file.

## Recent Changes

- Enhancement: Create icons for library and Web resources. [#229](https://github.com/zowe/cics-for-zowe-client/issues/229)

## `3.3.3`
- BugFix: Duplicate CICSplex exist when connecting to a multi-CMAS system. [#227](https://github.com/zowe/cics-for-zowe-client/issues/227)
- Enhancement: Show CMCI error response codes when failing to make requests. [#220](https://github.com/zowe/cics-for-zowe-client/issues/220)
Expand Down
15 changes: 15 additions & 0 deletions packages/vsce/resources/imgs/grouped-region-closed-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions packages/vsce/resources/imgs/grouped-region-closed-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions packages/vsce/resources/imgs/grouped-region-open-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions packages/vsce/resources/imgs/grouped-region-open-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 12 additions & 7 deletions packages/vsce/resources/imgs/library-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions packages/vsce/resources/imgs/library-dataset-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions packages/vsce/resources/imgs/library-dataset-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 12 additions & 8 deletions packages/vsce/resources/imgs/library-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions packages/vsce/resources/imgs/pipeline-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions packages/vsce/resources/imgs/pipeline-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions packages/vsce/resources/imgs/tcp-ip-service-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions packages/vsce/resources/imgs/tcp-ip-service-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions packages/vsce/resources/imgs/uri-map-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions packages/vsce/resources/imgs/uri-map-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions packages/vsce/resources/imgs/web-services-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions packages/vsce/resources/imgs/web-services-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 3 additions & 4 deletions packages/vsce/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export async function activate(context: ExtensionContext) {
} else {
window.showErrorMessage(
"Zowe Explorer was not found: either it is not installed or you are using an older version without extensibility API. " +
"Please ensure Zowe Explorer v2.0.0-next.202202221200 or higher is installed",
"Please ensure Zowe Explorer v2.0.0-next.202202221200 or higher is installed",
);
return;
}
Expand Down Expand Up @@ -90,7 +90,7 @@ export async function activate(context: ExtensionContext) {
);
};

const contextMap: { [key: string]: (node: any) => Promise<void> | void } = {
const contextMap: { [key: string]: (node: any) => Promise<void> | void; } = {
cicscombinedprogramtree: expandCombinedTree,
cicscombinedtransactiontree: expandCombinedTree,
cicscombinedlocalfiletree: expandCombinedTree,
Expand Down Expand Up @@ -161,7 +161,6 @@ export async function activate(context: ExtensionContext) {
"cicstreelocalfile.",
"cicstreetask.",
"cicstreelibrary.",
"cicslibrary.",
"cicstreeweb.",
"cicstreetcpips.",
"cicstreepipeline.",
Expand All @@ -177,4 +176,4 @@ export async function activate(context: ExtensionContext) {
});

context.subscriptions.concat(getCommands(treeDataProv, treeview));
}
}
2 changes: 1 addition & 1 deletion packages/vsce/src/trees/treeItems/CICSLibraryDatasets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class CICSLibraryDatasets extends TreeItem {
dataset: any,
parentRegion: CICSRegionTree,
directParent: any,
public iconPath = getIconFilePathFromName("library"),
public iconPath = getIconFilePathFromName("library-dataset"),
) {
super(`${dataset.dsname}`, TreeItemCollapsibleState.Collapsed);

Expand Down
6 changes: 2 additions & 4 deletions packages/vsce/src/trees/treeItems/CICSLibraryTreeItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { TreeItemCollapsibleState, TreeItem, window } from "vscode";
import { CICSRegionTree } from "../CICSRegionTree";
import { getResource } from "@zowe/cics-for-zowe-sdk";
import { CICSLibraryDatasets } from "./CICSLibraryDatasets";
import { getFolderIcon } from "../../utils/iconUtils";
import { getIconFilePathFromName } from "../../utils/iconUtils";
import { toArray } from "../../utils/commandUtils";

export class CICSLibraryTreeItem extends TreeItem {
Expand All @@ -27,7 +27,7 @@ export class CICSLibraryTreeItem extends TreeItem {
library: any,
parentRegion: CICSRegionTree,
directParent: any,
public iconPath = getFolderIcon(false),
public iconPath = getIconFilePathFromName("library"),
) {
super(`${library.name}`, TreeItemCollapsibleState.Collapsed);

Expand Down Expand Up @@ -69,14 +69,12 @@ export class CICSLibraryTreeItem extends TreeItem {
const newDatasetItem = new CICSLibraryDatasets(dataset, this.parentRegion, this); //this=CICSLibraryTreeItem
this.addDataset(newDatasetItem);
}
this.iconPath = getFolderIcon(true);
} catch (error) {
if (error.mMessage!.includes("exceeded a resource limit")) {
window.showErrorMessage(`Resource Limit Exceeded - Set a datasets filter to narrow search`);
} else if (this.children.length === 0) {
window.showInformationMessage(`No datasets found`);
this.label = this.buildLabel([]);
this.iconPath = getFolderIcon(true);
} else {
window.showErrorMessage(
`Something went wrong when fetching datasets - ${JSON.stringify(error, Object.getOwnPropertyNames(error)).replace(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class CICSPipelineTreeItem extends TreeItem {
pipeline: any,
parentRegion: CICSRegionTree,
directParent: any,
public readonly iconPath = getIconFilePathFromName("program"),
public readonly iconPath = getIconFilePathFromName("pipeline"),
) {
super(`${pipeline.name}`, TreeItemCollapsibleState.None);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class CICSTCPIPServiceTreeItem extends TreeItem {
tcpips: any,
parentRegion: CICSRegionTree,
directParent: any,
public readonly iconPath = getIconFilePathFromName("program"),
public readonly iconPath = getIconFilePathFromName("tcp-ip-service"),
) {
super(`${tcpips.name}`, TreeItemCollapsibleState.None);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class CICSURIMapTreeItem extends TreeItem {
urimap: any,
parentRegion: CICSRegionTree,
directParent: any,
public readonly iconPath = getIconFilePathFromName("program"),
public readonly iconPath = getIconFilePathFromName("uri-map"),
) {
super(`${urimap.name}`, TreeItemCollapsibleState.None);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class CICSWebServiceTreeItem extends TreeItem {
webservice: any,
parentRegion: CICSRegionTree,
directParent: any,
public readonly iconPath = getIconFilePathFromName("program"),
public readonly iconPath = getIconFilePathFromName("web-service"),
) {
super(`${webservice.name}`, TreeItemCollapsibleState.None);

Expand Down
Loading