-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
229 icons for resources and grouped regions #230
229 icons for resources and grouped regions #230
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 40.12% 40.13% +0.01%
==========================================
Files 149 149
Lines 5082 5080 -2
Branches 892 893 +1
==========================================
Hits 2039 2039
+ Misses 3043 3041 -2 ☔ View full report in Codecov by Sentry. |
c889ea2
to
12cf942
Compare
Signed-off-by: Rajat Sahrawat <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
5fbc095
to
c28ee78
Compare
Signed-off-by: Rajat Sahrawat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icons looks good. We can work on using the grouped-region
icons correctly in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments.
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Andrew Twydell <[email protected]>
9901c7a
to
42cb159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable - I've tested it locally and it seems good!
* Icons for resources and grouped regions Signed-off-by: Rajat Sahrawat <[email protected]> * Updated icons for Library and web resources Signed-off-by: Rushabh Sojitra <[email protected]> * updated changelog Signed-off-by: Rushabh Sojitra <[email protected]> * Refined grouped region icons Signed-off-by: Rajat Sahrawat <[email protected]> * Updated as some icons not visible on linux Signed-off-by: enam-khan <[email protected]> * updated icon for libraryTree Signed-off-by: Rushabh Sojitra <[email protected]> * Updated changelog Signed-off-by: Rushabh Sojitra <[email protected]> * prevent changing library icon on collapse event Signed-off-by: Andrew Twydell <[email protected]> --------- Signed-off-by: Rajat Sahrawat <[email protected]> Signed-off-by: Rushabh Sojitra <[email protected]> Signed-off-by: enam-khan <[email protected]> Signed-off-by: Andrew Twydell <[email protected]> Co-authored-by: Rajat Sahrawat <[email protected]> Co-authored-by: enam-khan <[email protected]> Co-authored-by: Andrew Twydell <[email protected]>
What It Does
Updated Icons for Library items, library datasets and web resources
Old Icons:

Updated Icons

How to Test
Review Checklist
I certify that I have:
Additional Comments