Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

229 icons for resources and grouped regions #230

Merged
merged 8 commits into from
Feb 13, 2025

Conversation

almightyrush
Copy link
Contributor

@almightyrush almightyrush commented Feb 11, 2025

What It Does
Updated Icons for Library items, library datasets and web resources

Old Icons:
image image

Updated Icons
image image

How to Test

Review Checklist
I certify that I have:

Additional Comments

@almightyrush almightyrush linked an issue Feb 11, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.13%. Comparing base (f4cb407) to head (42cb159).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/vsce/src/extension.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   40.12%   40.13%   +0.01%     
==========================================
  Files         149      149              
  Lines        5082     5080       -2     
  Branches      892      893       +1     
==========================================
  Hits         2039     2039              
+ Misses       3043     3041       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almightyrush almightyrush force-pushed the 229-icons-for-resources-and-grouped-regions branch from c889ea2 to 12cf942 Compare February 11, 2025 14:03
Rajat-Sahrawat and others added 3 commits February 13, 2025 11:18
@almightyrush almightyrush force-pushed the 229-icons-for-resources-and-grouped-regions branch from 5fbc095 to c28ee78 Compare February 13, 2025 05:48
Signed-off-by: Rajat Sahrawat <[email protected]>
Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons looks good. We can work on using the grouped-region icons correctly in a future PR.

Copy link
Contributor

@enamkhan enamkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

enamkhan and others added 2 commits February 13, 2025 13:36
Signed-off-by: Rushabh Sojitra <[email protected]>
Copy link
Contributor

@enamkhan enamkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@enamkhan enamkhan requested a review from davenice February 13, 2025 15:13
@AndrewTwydell AndrewTwydell force-pushed the 229-icons-for-resources-and-grouped-regions branch from 9901c7a to 42cb159 Compare February 13, 2025 15:20
Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable - I've tested it locally and it seems good!

@AndrewTwydell AndrewTwydell merged commit 3ff6d32 into main Feb 13, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the 229-icons-for-resources-and-grouped-regions branch February 13, 2025 16:32
@AndrewTwydell AndrewTwydell added the release-current Indicates that there is no new functionality being delivered label Feb 13, 2025
davenice pushed a commit that referenced this pull request Mar 11, 2025
* Icons for resources and grouped regions

Signed-off-by: Rajat Sahrawat <[email protected]>

* Updated icons for Library and web resources

Signed-off-by: Rushabh Sojitra <[email protected]>

* updated changelog

Signed-off-by: Rushabh Sojitra <[email protected]>

* Refined grouped region icons

Signed-off-by: Rajat Sahrawat <[email protected]>

* Updated as some icons not visible on linux

Signed-off-by: enam-khan <[email protected]>

* updated icon for libraryTree

Signed-off-by: Rushabh Sojitra <[email protected]>

* Updated changelog

Signed-off-by: Rushabh Sojitra <[email protected]>

* prevent changing library icon on collapse event

Signed-off-by: Andrew Twydell <[email protected]>

---------

Signed-off-by: Rajat Sahrawat <[email protected]>
Signed-off-by: Rushabh Sojitra <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Co-authored-by: Rajat Sahrawat <[email protected]>
Co-authored-by: enam-khan <[email protected]>
Co-authored-by: Andrew Twydell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Create icons for resources and grouped regions
6 participants