Test ESR wasm support #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacrelf
commented
Oct 26, 2021
Comment on lines
+69
to
+85
| // ESR 60.9 supports none of the newer features, but | ||
| // you would expect to have to change a few of these | ||
| // when newer ESRs are used in Zotero. | ||
| let expected = { | ||
| mutableGlobals: false, | ||
| bigInt: false, | ||
| bulkMemory: false, | ||
| exceptions: false, | ||
| memory64: false, | ||
| multiValue: false, | ||
| referenceTypes: false, | ||
| saturatedFloatToInt: false, | ||
| signExtensions: false, | ||
| simd: false, | ||
| tailCall: false, | ||
| threads: false, | ||
| }; |
|
This is great, thanks for adding it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integration test, ultimately means we keep track of which WASM features are supported by the ESR used in Zotero. Running against a new
zotero-standalone-buildwith a new ESR, e.g. ESR 78 or the new one coming in November will require updating this test case, so we'll know which ones it has brought support for. Thanks to https://github.com/GoogleChromeLabs/wasm-feature-detect for the feature detection.Related: #108