Integration testing on Zotero's Firefox ESR #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #84; this fixes it and removes the version pin. Also upgrades CI to rust stable 1.51
|
This is great — thanks for setting this up. (Hopefully we'll make it obsolete…soon?) |
cormacrelf
added
A-ci
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #84 again. Upstream
[email protected]added a shim to avoid using mutable globals altogether, so it has been upgraded and the workarounds removed. This also means wasm-opt is back! Yay, binaries will be ever so slightly smaller again.I wanted to be sure this wouldn't happen again, so I added an integration test using the exact version of Firefox ESR Zotero uses to GitHub CI to make sure everything runs there. As in, fetches
zotero-standalone-build, uses the script to download Firefox, and usesselenium-webdriverto load up a test page and wait for it to write a success value into the DOM. It will break iffetch_xulrunner.shis changed too much, but that's OK, I assume if that's happening then there will be some other good things happening to balance it out :)Instructions in the js-tests README.md if you wish to to try it yourself. Caveats: may leave zombie Firefox processes lying around on your system. 60.9 is oooold, selenium is kinda shaky at killing it.