-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects: Add subject index pages #1875
Conversation
Note that client-side routing with |
We should give pages like these unique titles, so that they can be distinguished in the browser history, or when bookmarked, or in link previews. Returning a |
If a volunteer bookmarks one of these pages, what happens when they come back? Should they get the specified subject, but with an 'Already Seen' banner? |
Returning to an already-classified subject would display the The modal has two options: to return to the project home page or to choose another subject from the subject set. Choosing another subject opens the modal to choose another subject within the classify page: https://projects.invisionapp.com/d/main#/console/12924056/440898093/preview Should be able to reuse the modal from the project home page on the classify pages, but should not include the 'back to workflow selection' button and has different text ('choose a subject' rather than 'choose a subject to get started'). |
130b51d
to
9884a36
Compare
@beckyrother we already have subject banners in the classifier. At the moment, there isn't really a mechanism to show different banners for different projects or workflows. |
Wishful thinking I guess. Let's just show those current banners. It would be nice to have a quick way to go back to subject selection like the modal would do, but if that's not possible they'll just have to go back. |
We could maybe change the messaging depending on the type of workflow that you're working on. I'm not sure how flexible those banners are. |
7dfd43e
to
3d64b7b
Compare
9884a36
to
7986246
Compare
1348c8f
to
079dffd
Compare
7986246
to
e5216ee
Compare
e5216ee
to
e40ef4c
Compare
be6bbf0
to
40bf6c4
Compare
Add subject index pages for /workflow/[workflowID]/subjectSet/[subjectSetID]/subject/[subjectID] and /workflow/[workflowID]/subject/[subjectID]. Pass the subject ID down to the classifier as a prop.
40bf6c4
to
86f7cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review
Package: app-project
Context: AFAIU, the Engaging Crowds project (2020-2021) is introducing sequential Subjects, and this is part of the larger solution.
This PR adds new possible paths for the front end. Specifically, these paths allow us to specify specific Subjects IDs for the Classifier to serve.
- Example paths:
- http://localhost:3000/projects/darkeshard/transformers/classify/workflow/3453/subject/48406
- http://localhost:3000/projects/darkeshard/transformers/classify/workflow/3453/subject-set/4042/subject/48406
- (emphasis on the /subject/48406 for specifying Subject 48406)
This PR is part of a larger solution. The SubjectID is being passed down to the Classifier, but the Classifier doesn't do anything with it - yet.
Testing
Basic path testing on mac OS 10 + Chrome 88. Opening the example paths listed above lead to the Classifier and not a 404, which is all I'm looking for. No other paths are affected.
Status
LGTM 👍
Add subject index pages for
/classify/workflow/[workflowID]/subject-set/[subjectSetID]/subject/[subjectID]
and/classify/workflow/[workflowID]/subject/[subjectID]
. Pass the subject ID down to the classifier as a prop.Package:
app-project
Review Checklist
General
Components
Apps
yarn panic && yarn bootstrap
ordocker-compose up --build
and app works as expected?Publishing
Post-merging