-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New translation to spanish language. #219
Conversation
Travis failed during its setup phase. I restarted the tests to see if the problem has been solved. |
@huguei, can you rebase this PR on latest version of develop branch and then do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as far as I can tell. I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My wrong. Rebase to latest version of develop branch is still need.
Updated to the last develop version, and translated fuzzy messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two untranslated items.
Done. Sorry about that. I'm using poedit and although it highlights the fuzzy messages, it doesn't mark enough the empty ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I approve.
#~ msgid "The minimum severity level to display" | ||
#~ msgstr "El nivel mínimo de gravedad que despliega" | ||
|
||
#~ msgid "Name of configuration file to load." | ||
#~ msgstr "Nombre del archivo de configuración a cargar." | ||
|
||
#~ msgid "Loading configuration from {path}." | ||
#~ msgstr "Cargando configuración desde {path}." | ||
|
||
#~ msgid "Print the effective configuration used in JSON format, then exit." | ||
#~ msgstr "" | ||
#~ "Despliega la configuración definitiva usada en formato JSON, luego " | ||
#~ "termina." | ||
|
||
#~ msgid "" | ||
#~ "Local IP address that the test engine should try to send its requests " | ||
#~ "from." | ||
#~ msgstr "" | ||
#~ "Dirección IP local que debería usar el motor de pruebas como origen de " | ||
#~ "sus solicitudes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be safe to remove those lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It is safe both to keep and remove. If we keep them now I will check all PO files after the v2021.2.1 release and create a clean-up PR. Is that OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for me to defer the removal (as long as we don't forget about it :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not. @PNAX, please approve.
Following the same conventions of zonemaster-engine translation instructions.