Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New translation to spanish language. #219

Merged
merged 4 commits into from
Dec 17, 2021
Merged

New translation to spanish language. #219

merged 4 commits into from
Dec 17, 2021

Conversation

huguei
Copy link
Collaborator

@huguei huguei commented Nov 2, 2021

Following the same conventions of zonemaster-engine translation instructions.

@mattias-p
Copy link
Member

Travis failed during its setup phase. I restarted the tests to see if the problem has been solved.

@matsduf
Copy link
Contributor

matsduf commented Nov 16, 2021

@huguei, can you rebase this PR on latest version of develop branch and then do make es.po. Follow the relevant sections of https://github.com/zonemaster/zonemaster-engine/blob/develop/docs/Translation-translators.md

@matsduf matsduf added the A-Translation Area: Documentation of, implementation of or actual translation of text label Nov 16, 2021
@matsduf matsduf added this to the v2021.2 milestone Nov 16, 2021
@matsduf matsduf modified the milestones: v2021.2, v2021.2.1 Dec 5, 2021
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. I approve.

@matsduf matsduf requested review from hannaeko and a user December 10, 2021 07:50
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My wrong. Rebase to latest version of develop branch is still need.

@huguei
Copy link
Collaborator Author

huguei commented Dec 10, 2021

Updated to the last develop version, and translated fuzzy messages.

Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two untranslated items.

share/es.po Show resolved Hide resolved
share/es.po Outdated Show resolved Hide resolved
@huguei
Copy link
Collaborator Author

huguei commented Dec 10, 2021

Done. Sorry about that. I'm using poedit and although it highlights the fuzzy messages, it doesn't mark enough the empty ones.

Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I approve.

Comment on lines +266 to +285
#~ msgid "The minimum severity level to display"
#~ msgstr "El nivel mínimo de gravedad que despliega"

#~ msgid "Name of configuration file to load."
#~ msgstr "Nombre del archivo de configuración a cargar."

#~ msgid "Loading configuration from {path}."
#~ msgstr "Cargando configuración desde {path}."

#~ msgid "Print the effective configuration used in JSON format, then exit."
#~ msgstr ""
#~ "Despliega la configuración definitiva usada en formato JSON, luego "
#~ "termina."

#~ msgid ""
#~ "Local IP address that the test engine should try to send its requests "
#~ "from."
#~ msgstr ""
#~ "Dirección IP local que debería usar el motor de pruebas como origen de "
#~ "sus solicitudes."
Copy link

@ghost ghost Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safe to remove those lines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is safe both to keep and remove. If we keep them now I will check all PO files after the v2021.2.1 release and create a clean-up PR. Is that OK?

Copy link

@ghost ghost Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me to defer the removal (as long as we don't forget about it :) )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not. @PNAX, please approve.

@matsduf matsduf merged commit 6a9538d into zonemaster:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants