Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate The docs Project #315

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Aggregate The docs Project #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
97e92d6
aggregate docs project.
khajavi Jan 16, 2023
2a04fb2
remove dependsOn.
khajavi Jan 16, 2023
f4739a8
add zio to docs project.
khajavi Jan 16, 2023
576c315
skip publishing root module.
khajavi Jan 17, 2023
d07d958
depend on zio-ftp.
khajavi Jan 17, 2023
856efdf
disable aggregating docs on update task.
khajavi Jan 17, 2023
e4141d1
use specific submodule for testing.
khajavi Jan 17, 2023
6104763
remove extra settings.
khajavi Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
chmod -R 777 ./zio-ftp/ftp-home/sftp/home/foo/dir1
- name: Test 2.x
if: ${{ !startsWith(matrix.scala, '3.') }}
run: ./sbt ++${{ matrix.scala }} test
run: ./sbt ++${{ matrix.scala }} zio-ftp/test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand why we need to create a subfolder zio-ftp.
Please revert it.
Since it is a single module, we dont need to create this layer

When you are cloning the repo, you will have zio-ftp/zio/ftp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regis-leray
This PR contains two modules zio-ftp and the docs module. So it is not a single module. If you wish, I can revert that. But would like to know what is your concern about these changes.

# - name: Test 3.x
# if: ${{ startsWith(matrix.scala, '3.') }}
# run: ./sbt ++${{ matrix.scala }}! testDotty
Expand Down
4 changes: 2 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ addCommandAlias("fix", "; all compile:scalafix test:scalafix; all scalafmtSbt sc
val zioVersion = "2.0.0"

lazy val root =
project.in(file(".")).settings(publish / skip := false).aggregate(`zio-ftp`)
project.in(file(".")).settings(publish / skip := true).aggregate(`zio-ftp`, docs)

lazy val `zio-ftp` = project
.in(file("zio-ftp"))
Expand Down Expand Up @@ -58,7 +58,7 @@ lazy val docs = project
moduleName := "zio-ftp-docs",
scalacOptions -= "-Yno-imports",
scalacOptions -= "-Xfatal-warnings",
test / aggregate := false,
libraryDependencies ++= Seq("dev.zio" %% "zio" % zioVersion),
scalaVersion := Scala213,
crossScalaVersions := Seq(Scala212, Scala213),
projectName := "ZIO FTP",
Expand Down