Aggregate The docs Project #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regis-leray
reviewed
Jan 17, 2023
| @@ -67,7 +67,7 @@ jobs: | |||
| chmod -R 777 ./zio-ftp/ftp-home/sftp/home/foo/dir1 | |||
| - name: Test 2.x | |||
| if: ${{ !startsWith(matrix.scala, '3.') }} | |||
| run: ./sbt ++${{ matrix.scala }} test | |||
| run: ./sbt ++${{ matrix.scala }} zio-ftp/test | |||
There was a problem hiding this comment.
i dont understand why we need to create a subfolder zio-ftp.
Please revert it.
Since it is a single module, we dont need to create this layer
When you are cloning the repo, you will have zio-ftp/zio/ftp
There was a problem hiding this comment.
@regis-leray
This PR contains two modules zio-ftp and the docs module. So it is not a single module. If you wish, I can revert that. But would like to know what is your concern about these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.