Correct Core Installer Translation #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on user selection.
craigh
changed the title
|
@Guite ready for review |
craigh
changed the title
Guite
reviewed
Nov 18, 2016
| $event = new ModuleStateEvent($this->container->get('kernel')->getModule('ZikulaRoutesModule')); | ||
| $this->container->get('event_dispatcher')->dispatch(CoreEvents::MODULE_POSTINSTALL, $event); | ||
| // $event = new ModuleStateEvent($this->container->get('kernel')->getModule('ZikulaRoutesModule')); | ||
| // $this->container->get('event_dispatcher')->dispatch(CoreEvents::MODULE_POSTINSTALL, $event); |
There was a problem hiding this comment.
I guess this got disabled because now only customised routes are persisted in the database? If yes, you can also remove it.
There was a problem hiding this comment.
basically yes. I disabled it because it isn't needed. I left the code commented because removing it means the ajax stage should be fully removed and I didn't want to take the time to do that yet.
|
Go for it ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable scan of locales on installation and set locale for installer based on user selection. Add translator usage to many parts of the core installer and upgrader.
closes #2191