Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure translation works in Installer Bundle #2191

Closed
craigh opened this issue Jan 19, 2015 · 27 comments
Closed

Make sure translation works in Installer Bundle #2191

craigh opened this issue Jan 19, 2015 · 27 comments

Comments

@craigh
Copy link
Member

craigh commented Jan 19, 2015

Currently unknown whether translation works at all in CoreInstallerBundle. The method \Zikula\Bundle\CoreInstallerBundle\Util\ControllerUtil::setupLang() is currently unused and may be required for translation

A functional translation of the strings will be required to see if it works ;-)

@cmfcmf
Copy link
Contributor

cmfcmf commented Jan 20, 2015

Make also sure the translation of the route works, depends on #2138.

@rallek
Copy link
Contributor

rallek commented Jan 20, 2015

Is an actual pot file available? I started the German translation for an older build

@craigh
Copy link
Member Author

craigh commented Jan 25, 2015

@Guite how do we regenerate the core pot file?

@craigh
Copy link
Member Author

craigh commented Jan 26, 2015

@Guite will you please regenerate the POT file and document how to do it for the rest of us?

@Guite
Copy link
Member

Guite commented Jan 26, 2015

Yes. Also I will check how much effort is creating a CI job doing the pot generation.

@Guite
Copy link
Member

Guite commented Jan 26, 2015

Pot files are regenerated in f98258f

To do this:

  1. Clone https://github.com/zikula-modules/Gettext/ into the modules/ folder
  2. Open a console and navigate into modules/Gettext/Helper
  3. Call xtractcore.sh path/to/src/

Going to challenge a CI job for this next.

@craigh
Copy link
Member Author

craigh commented Jan 27, 2015

maybe the core extract files could be moved right to the core repo in the /Tools dir. unless they also require other elements of the module.

@craigh
Copy link
Member Author

craigh commented Jan 27, 2015

the strings in the twig templates of the installer are not extracted: zikula-modules/Gettext#8

@Guite
Copy link
Member

Guite commented Jan 27, 2015

It is not easily possible to separate only the core extract files.

@Guite
Copy link
Member

Guite commented Jan 28, 2015

The POT creation is now working as a proof of concept:
http://ci.zikula.org/job/Zikula_Core-1.4-POT/

@craigh
Copy link
Member Author

craigh commented Jan 29, 2015

@Guite - I've spent some time trying to figure out how to make the twig files work in our Gettext extractor and can't figure it out. it is WAY above my head. can you take a look?

@Guite
Copy link
Member

Guite commented Jan 30, 2015

No I am no regex guru.

@shefik
Copy link
Contributor

shefik commented Feb 23, 2015

@craigh Since you changed the milestone for this particular ticket to 1.4.1, I assume that means translations for the installer of Zikula 1.4.0 are not included in that release at all?

@craigh
Copy link
Member Author

craigh commented Feb 23, 2015

right. this is quite complicated actually.

@craigh craigh modified the milestones: 1.4.0, 1.4.1 Jun 17, 2015
@craigh
Copy link
Member Author

craigh commented Jun 17, 2015

@shefik @Kaik @rallek

.pot files are now in place for the installer. It would be great if someone could create a .po file and test translation in the installer.

If it works, then we can close this ticket. If it doesn't then we will probably postpone (again) to 1.4.1. but if someone can test, that would be terrific!

@shefik
Copy link
Contributor

shefik commented Jun 17, 2015

I can test it.

@rallek
Copy link
Contributor

rallek commented Nov 10, 2015

first I would need an actual translation ;-). I will give it a try with a translation of 1.3.5. Some strings should be availble already.

@rallek
Copy link
Contributor

rallek commented Nov 10, 2015

I tried without success!
Fresh download of ci build 113. uploaded the german translation into /app/Resources/locale/de/LC_MESSAGES (both po and mo files) and start web installer.

I do not get the chance to choose the language.

Next I opend the zikula.po in Poedit. Downloaded the actual pot file from ci server, updated the zikula.po in poedit. Now I want to translate the first page of installer. But I can not find the string Zikula Core is not installed!! Is the installer not included in the translation?

@craigh
Copy link
Member Author

craigh commented Nov 10, 2015

you are editing the wrong file. :-)

these are the files to translate:

https://github.com/zikula/core/tree/1.4/src/lib/Zikula/Bundle/CoreInstallerBundle/Resources/translations

@craigh
Copy link
Member Author

craigh commented Nov 10, 2015

@rallek
Copy link
Contributor

rallek commented Nov 10, 2015

And where to place the translation? I am confused. How many translation files we do have? It is not included into pot file generation at ci server :-(

@craigh
Copy link
Member Author

craigh commented Nov 10, 2015

In the future, the files must be placed into the new app/Resources/translations folder. In this case, copy all files to <filename>.<lang>.po (for example routes.template.po => routes.de.po) and translate the .po files as usual to generate the .mo files.

@rallek
Copy link
Contributor

rallek commented Nov 11, 2015

I tried this folder and the standard folder of zikula translation. Both do not work.

@rallek
Copy link
Contributor

rallek commented Nov 12, 2015

@Kaik will hopefully try next week. Translation makes trouble at all: #2642

@craigh craigh modified the milestones: 1.4.1, 1.4.2 Nov 23, 2015
@craigh craigh modified the milestones: 1.4.2, 1.4.3 Feb 26, 2016
@craigh craigh modified the milestones: 1.4.3, 1.4.4 Jul 11, 2016
@Guite Guite modified the milestones: 1.4.4, 1.4.5 Sep 2, 2016
@craigh craigh modified the milestones: 1.4.4, 1.4.5 Nov 17, 2016
@craigh craigh self-assigned this Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants