-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure translation works in Installer Bundle #2191
Comments
Make also sure the translation of the route works, depends on #2138. |
Is an actual pot file available? I started the German translation for an older build |
@Guite how do we regenerate the core pot file? |
@Guite will you please regenerate the POT file and document how to do it for the rest of us? |
Yes. Also I will check how much effort is creating a CI job doing the pot generation. |
Pot files are regenerated in f98258f To do this:
Going to challenge a CI job for this next. |
maybe the core extract files could be moved right to the core repo in the /Tools dir. unless they also require other elements of the module. |
the strings in the twig templates of the installer are not extracted: zikula-modules/Gettext#8 |
It is not easily possible to separate only the core extract files. |
The POT creation is now working as a proof of concept: |
@Guite - I've spent some time trying to figure out how to make the twig files work in our Gettext extractor and can't figure it out. it is WAY above my head. can you take a look? |
No I am no regex guru. |
@craigh Since you changed the milestone for this particular ticket to 1.4.1, I assume that means translations for the installer of Zikula 1.4.0 are not included in that release at all? |
right. this is quite complicated actually. |
.pot files are now in place for the installer. It would be great if someone could create a .po file and test translation in the installer. If it works, then we can close this ticket. If it doesn't then we will probably postpone (again) to 1.4.1. but if someone can test, that would be terrific! |
I can test it. |
first I would need an actual translation ;-). I will give it a try with a translation of 1.3.5. Some strings should be availble already. |
I tried without success! I do not get the chance to choose the language. Next I opend the zikula.po in Poedit. Downloaded the actual pot file from ci server, updated the zikula.po in poedit. Now I want to translate the first page of installer. But I can not find the string |
you are editing the wrong file. :-) these are the files to translate: |
And where to place the translation? I am confused. How many translation files we do have? It is not included into pot file generation at ci server :-( |
|
I tried this folder and the standard folder of zikula translation. Both do not work. |
Currently unknown whether translation works at all in CoreInstallerBundle. The method
\Zikula\Bundle\CoreInstallerBundle\Util\ControllerUtil::setupLang()
is currently unused and may be required for translationA functional translation of the strings will be required to see if it works ;-)
The text was updated successfully, but these errors were encountered: