This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[WIP] twig gettext extraction #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks wrong. It should only check for Twig Gettext syntax. It should also check in more places. |
|
perhaps you missed this part:
😉 feel free to ignore, but we need a fix of some kind! |
|
No, I didn't miss it 😝 I don't have time to fix this myself ATM. |
|
ping @Drak help please |
|
refs #8 and zikula/core#2191 and templates in use here: https://github.com/zikula/core/tree/1.4/src/lib/Zikula/Bundle/CoreInstallerBundle/Resources/views |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8
@cmfcmf @Guite @Drak
I have NO IDEA what I'm doing here. making a stab at it. pretty sure it's missing the final step