Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fc features #2560

Merged
merged 75 commits into from
Aug 16, 2015
Merged

Fc features #2560

merged 75 commits into from
Aug 16, 2015

Conversation

cmfcmf
Copy link
Contributor

@cmfcmf cmfcmf commented Aug 11, 2015

No description provided.

craigh added 30 commits August 11, 2015 08:52
@craigh
Add TranslatorTrait refs #2493
be69e05
@craigh
Add schema_tool service (replaces util/DoctrineHelper)
aaaee48
@craigh
add ExtensionInstallerInterface refs #2500
a5165d9
@craigh
refactor ExtensionsModule Api methods to account for new ExtensionIns…
9c61a55 
…tallerInterface and abstract some of the functionality to avoid code duplication. refs #2500
@craigh
add HookContainer to ease installation and setup for hooks
099365d
@craigh
remove unneeded code since Version file no longer exists
94a758e
@craigh
allow getting Bundle MetaData from Bundle class
fd770c3
@craigh
set extensionType (e.g. /modules or /system) when decoding json o…
d9b77bb 
…n scan
@craigh
show minversion of dependency in table
fd0c727
@craigh
expand MetaData to accomodate all the version info that is now coming…
ba20b1d 
… from composer.json. Refactor (as FC) ExtensionsAdminApi to gather data from new source if available.
@craigh
refactor (with FC/BC) DependencyEntity to pull dependencies from new …
6fb0959 
…location.
@craigh
handle new dependency types
6a73eb8
@craigh
use newly available route to create url
f33bd55
@craigh
CS
c3753b8
@craigh
add vierbergenlars/php-semver to vendors and implement version compar…
cdaad1b 
…e using this lib. Also move zikula/core version compatibility to extra/zikula/core-compatibility and out of require
@craigh
correct variable spelling. use variable when passing by reference and…
262ac29 
… metadata must (for now) include 'core_max'
@craigh
[FC] Core should know from module metadata if it supports categorizat…
e1adb37 
…ion and for which entities it supports. refs #411.

This implements a key in the `capabilities` module as described in the ticket (using American spelling - categorizable). the value for the key is an array of FQ Entity names.
@craigh
add AdminResponse and check. refs #2112 and refs #2500
fdc2adc
@craigh
correct copy/paste error
ae72053
@craigh
use capabilities array to set 'default' admin link where possible. refs
e4831d7 
#2500
@craigh
refactor generic url generation for user index to use capability if a…
db11155 
…vailable.
@craigh
replace old AdminApi::getLinks system with new service definition and…
e233022 
… DI. refs #2500 and refs #2494

will require documentation.

see companion commit in Pages module (FC-features branch) for implementation.

/cc @cmfcmf
@craigh
remove commented code
da0a348
@craigh
add additional Response types
dd0d470
@craigh
remove unneeded comment
994dd9d
@craigh
allow for possible missing .ini files in theme
27d9e4f
@craigh
refactor theme scanner for new Core-2.0 type themes
e3e1921
@craigh
add additional twig extension template functions pageGetVar and getMo…
ea07f94 
…dVar (experimental)
@craigh
first attempts at loading a twig-based theme and accounting for Respo…
4fdf6a7 
…nse types (not functional at the moment)
@craigh
update listener to work sort of
fc19e05
cmfcmf
cmfcmf reviewed Aug 11, 2015
View reviewed changes
src/lib/Zikula/Core/Theme/Engine.php
private function setMatchingRealm()
{
foreach ($this->themeBundle->getConfig() as $realm => $config) {
if (!empty($config['pattern'])) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how the pattern is matched against everything - I'd like to see three distinct settings for these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge as is and then open a discussion on the topic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I am not clear on what you mean by "three distinct settings"

@cmfcmf
Copy link
Contributor Author

cmfcmf commented Aug 11, 2015

Looking good overall. Thank you @craigh for your work!

craigh added 4 commits August 11, 2015 16:52
@craigh
correct param signature in phpdoc
73d454e
@craigh
remove unneeded try/catch blocks
424ed7b
@craigh
CS
15967ba
@craigh
many changes to enable Asset management including adding and setting …
46c3b5f 
…pageVars and including assets. Also add default assets (e.g. bootstrap, etc) and begins refactoring of service names to new naming convention. maintains BC and uses similar methods to past. refs #2559
@craigh
Copy link
Member

craigh commented Aug 12, 2015

@cmfcmf - some big changes since your review today. ⛵

@craigh
Copy link
Member

craigh commented Aug 12, 2015

hmm. travis failed to install with this error:

[Symfony\Component\DependencyInjection\Exception\RuntimeException] A string value must be composed of strings and/or numbers, but found parameter "router.request_context.base_url" of type NULL inside string value "%router.request_context.base_url%/web/jquery/jquery.min.js".

which means the installer is broken for a minute. I guess I will follow up with the @todo in that section to fix the error...

@craigh
Copy link
Member

craigh commented Aug 15, 2015

@cmfcmf @Guite I would really like to merge this now. please voice any objections ASAP.

@cmfcmf - the StyleCI analyzer works better now (see output) but needs adjustment to allow spaces before and after concatenation dots (e.g. $foo . $bar instead of $foo.$bar) and there are maybe some other adjustments that can be made (again see output).

@Guite
Copy link
Member

Guite commented Aug 16, 2015

No objections from me. What I've seen looks very promising!

@Guite
Copy link
Member

Guite commented Aug 16, 2015

about StyleCI @cmfcmf : maybe switch from recommended to symfony ?
https://styleci.readme.io/docs/configuration
(should probably be discussed in a separate issue)

@cmfcmf
Copy link
Contributor Author

cmfcmf commented Aug 16, 2015

Merge if you like.

About styleci, I just briefly tried it but haven't configured anything yet,
feel free to do so or open an issue.
Axel Guckelsberger [email protected] schrieb am So., 16. Aug. 2015
um 08:36:

about StyleCI @cmfcmf https://github.com/cmfcmf : maybe switch from
recommended to symfony ?
https://styleci.readme.io/docs/configuration
(should probably be discussed in a separate issue)

—
Reply to this email directly or view it on GitHub
#2560 (comment).

craigh added a commit that referenced this pull request Aug 16, 2015
@craigh
Merge pull request #2560 from zikula/FC-features
9a03f3e 
Fc features
@craigh craigh merged commit 9a03f3e into 1.4 Aug 16, 2015
@craigh craigh deleted the FC-features branch August 16, 2015 11:11
@craigh craigh mentioned this pull request Aug 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmfcmf @craigh @Guite