Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default_max_depth in fmt to be configured from root. #5412

Closed
wants to merge 3 commits into from

Conversation

Sircular
Copy link
Contributor

This PR copies the pattern from io.zig of setting a top-level declaration for module-wide parameters. This would close issue #2370.

@data-man
Copy link
Contributor

This way isn't flexible, e.g. depth can't be changed in runtime.

Possible solutions:

  • make default_max_depth as pub var
  • add set_max_depth function (returns old depth)

@andrewrk andrewrk added proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. standard library This issue involves writing Zig code for the standard library. labels Jul 27, 2020
@andrewrk
Copy link
Member

andrewrk commented Jul 27, 2020

Can you go through the proposal process for this one (file an issue proposing to do this)? I have some ideas about how to do this in a way that avoids second-order effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants