-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: Make default_max_depth configurable #12310
Conversation
Would like to see what @andrewrk thinks about this, considering the closed PR, and that there seems to have been no further discussion since. |
I don't feel that this is a workaround. The default should be configurable IMO, and should be able to be overridden on a case-by-case basis. |
Anyway, I'd like to hear Andrew's thoughts on this, considering he had some plan in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated to use std.options
.
Will get that done soon :) |
Haven't been programming for a while, so please give my changes a little scrutiny ;) |
There is currently no way to override this when using
std.fmt.fmt()
, and derived functions (anything.print()
,std.log
, etc). This small change allows overriding the default value. In future, there should likely be a specifier in the fmt string. That is probably best to be discussed in #1358, or an offshoot issue.Closes #2370