Remove outdated TODO comment in lib/std/start.zig #12053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm new to zig and I'm so fascinated with it that I just started looking for some quick issues to tackle as the first contribution for me.
I thought this issue should be a good start, soon realizing that apparently it is already resolved except that one outdated TODO comment remains there. In fact, grep gives me the following result:
And the function that follows this TODO comment,
posixCallMainAndExit
, seems to be already taking advantage of sentinel-terminated pointers (I suppose this commit is relevant). So I have concluded that this comment should be outdated.Resolves #3767