Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated TODO comment in lib/std/start.zig #12053

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

magurotuna
Copy link
Contributor

Hi, I'm new to zig and I'm so fascinated with it that I just started looking for some quick issues to tackle as the first contribution for me.

I thought this issue should be a good start, soon realizing that apparently it is already resolved except that one outdated TODO comment remains there. In fact, grep gives me the following result:

❯ rg 'issues/265'
lib/std/start.zig
364:// TODO https://github.com/ziglang/zig/issues/265

And the function that follows this TODO comment, posixCallMainAndExit, seems to be already taking advantage of sentinel-terminated pointers (I suppose this commit is relevant). So I have concluded that this comment should be outdated.

Resolves #3767

@jedisct1
Copy link
Contributor

jedisct1 commented Jul 9, 2022

Hi Yusuke!

And thank you so much for your first contribution 🥰

Yep, looks like this comment is indeed not relevant any more. Good catch!

@jedisct1 jedisct1 merged commit f1da93a into ziglang:master Jul 9, 2022
@magurotuna magurotuna deleted the remove-outdated-todo-comment branch July 9, 2022 14:14
andrewrk pushed a commit that referenced this pull request Jul 19, 2022
wooster0 pushed a commit to wooster0/zig that referenced this pull request Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish taking advantage of sentinel-terminated pointers in the standard library
2 participants